Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nb_samples parameter in evaluate function #355

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Added nb_samples parameter in evaluate function #355

merged 2 commits into from
Oct 7, 2024

Conversation

jverre
Copy link
Collaborator

@jverre jverre commented Oct 4, 2024

Details

Added a nb_samples option to evaluate function

@jverre jverre requested a review from a team as a code owner October 4, 2024 20:58
@dsblank dsblank changed the title Added nb_samples parameter in eveluate function Added nb_samples parameter in evaluate function Oct 5, 2024
japdubengsub
japdubengsub requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@japdubengsub japdubengsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a test to verify that using the parameter nb_samples returns the expected result

@japdubengsub japdubengsub self-requested a review October 7, 2024 16:03
@jverre jverre merged commit 1096e06 into main Oct 7, 2024
21 checks passed
@jverre jverre deleted the jacques/add_sample_size_dataset branch October 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japdubengsub japdubengsub japdubengsub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jverre @japdubengsub