-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-271] Add integration with aws bedrock #529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onse is now wrapped and response is returned. Metadata from the start of the span/trace is now merged with the metadata from the end of the span/trace.
jverre
reviewed
Nov 4, 2024
@@ -203,6 +204,13 @@ def log_feedback_score( | |||
class TraceData: | |||
""" | |||
The TraceData object is returned when calling :func:`opik.opik_context.get_current_trace_data` from a tracked function. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexkuzmik These get documented in the public docs, let's move these to a comment in the code itself
jverre
reviewed
Nov 4, 2024
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
apps/opik-documentation/documentation/docs/cookbook/bedrock.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacques Verré <jverre@gmail.com>
Pass project_name directly when possible Add screenshots
* Added Opik.search_spans method
* [OPIK-309] Create prompt endpoint * Add logic to create first version when specified * Address PR review comments
@japdubengsub ready for review |
japdubengsub
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds an integration to AWS Bedrock clients that works similarly to openai integration.
Testing
Manual testing only was performed. Library integration test can be added only after we configure AWS credentials with access to bedrock in CI.
Documentation
Added a docstring.