Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-271] Add integration with aws bedrock #529

Merged
merged 27 commits into from
Nov 5, 2024

Conversation

alexkuzmik
Copy link
Collaborator

@alexkuzmik alexkuzmik commented Oct 31, 2024

Details

Adds an integration to AWS Bedrock clients that works similarly to openai integration.

Testing

Manual testing only was performed. Library integration test can be added only after we configure AWS credentials with access to bedrock in CI.

Documentation

Added a docstring.

@alexkuzmik alexkuzmik self-assigned this Oct 31, 2024
@alexkuzmik alexkuzmik requested a review from a team as a code owner October 31, 2024 15:29
@alexkuzmik alexkuzmik marked this pull request as draft October 31, 2024 15:29
@alexkuzmik alexkuzmik marked this pull request as ready for review November 4, 2024 12:45
@Lothiraldan Lothiraldan requested a review from a team as a code owner November 4, 2024 16:51
@@ -203,6 +204,13 @@ def log_feedback_score(
class TraceData:
"""
The TraceData object is returned when calling :func:`opik.opik_context.get_current_trace_data` from a tracked function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexkuzmik These get documented in the public docs, let's move these to a comment in the code itself

Lothiraldan and others added 4 commits November 5, 2024 10:45
Co-authored-by: Jacques Verré <jverre@gmail.com>
Pass project_name directly when possible
Add screenshots
* Added Opik.search_spans method
* [OPIK-309] Create prompt endpoint

* Add logic to create first version when specified

* Address PR review comments
@alexkuzmik
Copy link
Collaborator Author

@japdubengsub ready for review

@ferc ferc merged commit 9eca8dd into main Nov 5, 2024
21 checks passed
@ferc ferc deleted the OPIK-271-add-integration-with-aws-bedrock branch November 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants