[OPIK-310] Expose get prompts api #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/comet-ml/opik into thiagohora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-310_expose_get_prompts_api
thiagohora
force-pushed
the
thiagohora/OPIK-310_expose_get_prompts_api
branch
from
8104d91
to
81dfab6
Compare
idoberko2
reviewed
Nov 4, 2024
| " ORDER BY id DESC " + | ||
| " LIMIT :limit OFFSET :offset ") | ||
| @UseStringTemplateEngine | ||
| @AllowUnusedBindings |
| " WHERE workspace_id = :workspace_Id " + | ||
| " <if(name)> AND name like concat('%', :name, '%') <endif> ") | ||
| @UseStringTemplateEngine | ||
| @AllowUnusedBindings |
There was a problem hiding this comment.
Yeah, because of the string template. If the name is null, it will not render the where clause, and there will be no :name argument.
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/PromptResourceTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| @DisplayName("when search by name, then return prompt matching name") |
There was a problem hiding this comment.
It's worth adding a test for the case of a prompt exists and you search for it with a string that doesn't match the name to see that it is not returned
idoberko2
previously approved these changes
Nov 4, 2024
Base automatically changed from
thiagohora/OPIK-309_exposing_api_contracts
to
main
November 5, 2024 09:39
thiagohora
force-pushed
the
thiagohora/OPIK-310_expose_get_prompts_api
branch
from
d439827
to
ec2175e
Compare
idoberko2
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Find prompts
Issues
OPIK-310