OPIK-360 Andrei/projects crud tests #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2024 16:54
ferc
approved these changes
Nov 6, 2024
| def delete_project_by_name_sdk(name: str): | ||
| client = OpikApi() | ||
| project = find_project_by_name_sdk(name=name) | ||
| client.projects.delete_project_by_id(project[0]['id']) |
There was a problem hiding this comment.
Not sure why project is an array here, maybe find_project_by_name_sdk should just return the first element and that's it?
Comment on lines
+27
to
+38
| def wait_for_project_to_be_visible(project_name, timeout=10, initial_delay=1): | ||
| start_time = time.time() | ||
| delay = initial_delay | ||
|
|
||
| while time.time() - start_time < timeout: | ||
| if find_project_by_name_sdk(project_name): | ||
| return True | ||
|
|
||
| time.sleep(delay) | ||
| delay = min(delay*2, timeout-(time.time() - start_time)) | ||
|
|
||
| raise TimeoutError(f'could not get created project {project_name} via API within {timeout} seconds') |
There was a problem hiding this comment.
Pretty sure at some point we'll need an abstraction of this mechanism sending some function to wait until it's accomplished or throwing timeout as you did here (similar in TypeScript: https://playwright.dev/docs/test-assertions#expectpoll)
Comment on lines
+1
to
+10
| {"input": "Paris", "expected_output": "Hello, Paris!"} | ||
| {"input": "London", "expected_output": "Hello, London!"} | ||
| {"input": "New York", "expected_output": "Hello, New York!"} | ||
| {"input": "Tokyo", "expected_output": "Hello, Tokyo!"} | ||
| {"input": "Berlin", "expected_output": "Hello, Berlin!"} | ||
| {"input": "Sydney", "expected_output": "Hello, Sydney!"} | ||
| {"input": "Cairo", "expected_output": "Hello, Cairo!"} | ||
| {"input": "Toronto", "expected_output": "Hello, Toronto!"} | ||
| {"input": "Stockholm", "expected_output": "Hello, Stockholm!"} | ||
| {"input": "Sao Paulo", "expected_output": "Hello, Sao Paulo!"} |
There was a problem hiding this comment.
It's okay for now but maybe worth to make the mock data more diverse to cover more cases in one shot? (different structures, different fields, and so on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Created automated suite for testing all projects CRUD operations according to OPIK-360. Tests and their descriptions can be found inside test_projects_crud_operations.py
Reorganized file structure in tests_end_to_end for better separation between sanity tests and specific feature test suites. WILL ADD A WORKFLOW FILE TO TEST RUN THIS ON ACTIONS TOMORROW