Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-522] [Bug]: YAML is not correctly formatted for some strings #599

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions apps/opik-frontend/patches/js-yaml+4.1.0.patch
Original file line number Diff line number Diff line change
@@ -1,28 +1,19 @@
diff --git a/node_modules/js-yaml/dist/js-yaml.mjs b/node_modules/js-yaml/dist/js-yaml.mjs
index be71cad..77a71f2 100644
index be71cad..fe209ac 100644
--- a/node_modules/js-yaml/dist/js-yaml.mjs
+++ b/node_modules/js-yaml/dist/js-yaml.mjs
@@ -3017,7 +3017,8 @@ function isPrintable(c) {
@@ -3017,7 +3017,13 @@ function isPrintable(c) {
return (0x00020 <= c && c <= 0x00007E)
|| ((0x000A1 <= c && c <= 0x00D7FF) && c !== 0x2028 && c !== 0x2029)
|| ((0x0E000 <= c && c <= 0x00FFFD) && c !== CHAR_BOM)
- || (0x10000 <= c && c <= 0x10FFFF);
+ || (0x10000 <= c && c <= 0x10FFFF)
+ || c === CHAR_TAB;
}

// [34] ns-char ::= nb-char - s-white
diff --git a/node_modules/js-yaml/lib/dumper.js b/node_modules/js-yaml/lib/dumper.js
index f357a6a..c924262 100644
--- a/node_modules/js-yaml/lib/dumper.js
+++ b/node_modules/js-yaml/lib/dumper.js
@@ -196,7 +196,8 @@ function isPrintable(c) {
return (0x00020 <= c && c <= 0x00007E)
|| ((0x000A1 <= c && c <= 0x00D7FF) && c !== 0x2028 && c !== 0x2029)
|| ((0x0E000 <= c && c <= 0x00FFFD) && c !== CHAR_BOM)
- || (0x10000 <= c && c <= 0x10FFFF);
+ || (0x10000 <= c && c <= 0x10FFFF)
+ || c === CHAR_TAB;
+ || c === CHAR_TAB
+ || c === CHAR_LINE_FEED
+ || c === CHAR_CARRIAGE_RETURN
+ || c === 0x08
+ || c === 0x0B
+ || c === 0x0C;
}

// [34] ns-char ::= nb-char - s-white