Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go v1.21 #98

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Update to Go v1.21 #98

merged 4 commits into from
Dec 1, 2023

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Dec 1, 2023

In order to update the CometBFT E2E tests on main and for v1.x to make use of the latest release of cometbft-db (as per cometbft/cometbft#777 (comment)), we'll need to build the Docker test image using Go v1.21.

This PR needs to be applied before #97.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the dependencies Pull requests that update a dependency file label Dec 1, 2023
@thanethomson thanethomson requested a review from a team as a code owner December 1, 2023 14:13
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Copy link
Member

@hvanz hvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit debd991 Dec 1, 2023
8 checks passed
@thanethomson thanethomson deleted the thane/bump-go-1.21 branch December 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants