Clarifies that processProposal may be called for set of transactions different from the one returned in the preceding prepareProposal (backport #1033) #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…different from the one returned in the preceding prepareProposal (#1033) If a proposer fails after calling prepareProposal and before calling processProposal, then the following may happen upon restarting: - if failed before signing another message, then will invoke prepareProposal again, sign a new block, probably empty, and propose it; - if failed after signing a proposal but before writing the proposal message into the WAL, then will invoke prepareProposal and produce a new, probably empty block, [fail to sign it](https://github.com/cometbft/cometbft/blob/2789a59a9cc61c6ea56a6b266eeadf0f26ca2456/consensus/state.go#L1221), and not invoke processProposal; prevote timeouts will ensure the CometBFT is not stuck; - if failed after writing the proposal message to the WAL, then will invoke prepareProposal, produce a new, probably empty block, fail to sign it, and invoke processProposal with the block signed before crashing. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b23ef56) # Conflicts: # spec/abci/abci++_basic_concepts.md # spec/abci/abci++_comet_expected_behavior.md
lasarojc
approved these changes
Jun 29, 2023
3 tasks
nivasan1
pushed a commit
to skip-mev/cometbft
that referenced
this pull request
Jan 16, 2024
…different from the one returned in the preceding prepareProposal (backport cometbft#1033) (cometbft#1053) * Clarifies that processProposal may be called for set of transactions different from the one returned in the preceding prepareProposal (cometbft#1033) If a proposer fails after calling prepareProposal and before calling processProposal, then the following may happen upon restarting: - if failed before signing another message, then will invoke prepareProposal again, sign a new block, probably empty, and propose it; - if failed after signing a proposal but before writing the proposal message into the WAL, then will invoke prepareProposal and produce a new, probably empty block, [fail to sign it](https://github.com/cometbft/cometbft/blob/2789a59a9cc61c6ea56a6b266eeadf0f26ca2456/consensus/state.go#L1221), and not invoke processProposal; prevote timeouts will ensure the CometBFT is not stuck; - if failed after writing the proposal message to the WAL, then will invoke prepareProposal, produce a new, probably empty block, fail to sign it, and invoke processProposal with the block signed before crashing. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b23ef56) # Conflicts: # spec/abci/abci++_basic_concepts.md # spec/abci/abci++_comet_expected_behavior.md * solving cherry pick conflicts * solving cherry pick conflicts --------- Co-authored-by: Lasaro <lasaro@informal.systems>
This was referenced Feb 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1033 done by Mergify.
Cherry-pick of b23ef56 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com