Replace Http Server + Add WebSockets #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the existing API endpoints to use aoihttp and added websocket notifications
|
Seems to work and the good news is that I noticed that aiohttp seems to already get pulled in by one of the dependencies. Small issue that I found is that I need to do CTRL-C twice to kill it now? |
|
Investigating the CTRL+C issue, I don't have it on Windows, trying to get it running via WSL |
This was for hiding an error on Windows, but it isn't required
Omer-ler
pushed a commit
to uglabs/ComfyUI
that referenced
this pull request
Nov 14, 2023
Added a function to load the directories in the optional file: extra_model_paths.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, implemented WebSockets to replace the current polling.
I was going to move the classes out to separate files, but for ease of reviewing i've left them in main but it might be worth you splitting them out