This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Fix ConnectionPool race condition #735
Labels
🐛 bug
Something isn't working
Comments
We could design a |
Obsolete as per decision in #779 to use libp2p. |
bors bot
added a commit
that referenced
this issue
Dec 12, 2019
1766: Bump reqwest from 0.9.22 to 0.9.24 r=mergify[bot] a=dependabot-preview[bot] Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.9.22 to 0.9.24. <details> <summary>Changelog</summary> *Sourced from [reqwest's changelog](https://github.com/seanmonstar/reqwest/blob/v0.9.24/CHANGELOG.md).* > ## v0.9.24 > > - Fix stray `dbg!` macro usage. > > ## v0.9.23 > > - Fix when passing a `Url` that contains a username and password, extract it and send as basic authorizaton ([#715](https://github-redirect.dependabot.com/seanmonstar/reqwest/issues/715)). </details> <details> <summary>Commits</summary> - [`bd36d53`](seanmonstar/reqwest@bd36d53) v0.9.24 - [`0e4d07f`](seanmonstar/reqwest@0e4d07f) remove stray dbg macro usage - [`a9dc7a7`](seanmonstar/reqwest@a9dc7a7) v0.9.23 - [`6334345`](seanmonstar/reqwest@6334345) support url with authority ([#735](https://github-redirect.dependabot.com/seanmonstar/reqwest/issues/735)) - See full diff in [compare view](seanmonstar/reqwest@v0.9.22...v0.9.24) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=reqwest&package-manager=cargo&previous-version=0.9.22&new-version=0.9.24)](https://dependabot.com/compatibility-score.html?dependency-name=reqwest&package-manager=cargo&previous-version=0.9.22&new-version=0.9.24) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now If two nodes try to connect to each other at the same time something nasty can happen.
node A -------------> node B
node A <------------- node B
node A will ignore node B's connection because it is already trying to connect and node B will ignore node A's connction because it is always trying to connect. Both connections will be dropped and so there will be no connection. Swap requests sent down any of these temporary connection will just die.
We need a design that doesn't have these problems but also doesn't allow nodes to spam other nodes with connections.
hint: Don't just drop incoming connections because you're connected or connecting. It's fine to allow a single incoming connection from a given node id.
Blocked by #739
The text was updated successfully, but these errors were encountered: