Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

update create message #384

Merged
merged 2 commits into from
Feb 1, 2020
Merged

update create message #384

merged 2 commits into from
Feb 1, 2020

Conversation

da-kami
Copy link
Member

@da-kami da-kami commented Jan 20, 2020

comit-scripts now handles start-env.
one cannot run it with create-comit-app.

@da-kami
update create message
f5e1b7a 
comit-scripts now handles start-env.
one cannot run it with create-comit-app.
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2020

Are you sure the changelog does not need updating?

@D4nte
Copy link
Contributor

D4nte commented Jan 20, 2020 •
edited
Loading

Please also update

eprintln!("It seems that `create-comit-app start-env` is already running.\nIf it is not the case, run `create-comit-app force-clean-env` and try again.");

D4nte
D4nte suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@D4nte D4nte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update

eprintln!("It seems that `create-comit-app start-env` is already running.\nIf it is not the case, run `create-comit-app force-clean-env` and try again.");

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 31, 2020
@bors @da-kami
Merge #384
06c8d5e 
384: update create message r=mergify[bot] a=da-kami

comit-scripts now handles start-env.
one cannot run it with create-comit-app.

Co-authored-by: Daniel Karzel <daniel.karzel@coblox.tech>
Co-authored-by: Franck Royer <franck@coblox.tech>
@D4nte
Copy link
Contributor

D4nte commented Jan 31, 2020

bors r+

@D4nte D4nte mentioned this pull request Jan 31, 2020
Closed
@D4nte
Copy link
Contributor

D4nte commented Feb 1, 2020

bors retry

bors bot added a commit that referenced this pull request Feb 1, 2020
@bors @da-kami
Merge #384
6d406f6 
384: update create message r=D4nte a=da-kami

comit-scripts now handles start-env.
one cannot run it with create-comit-app.

Co-authored-by: Daniel Karzel <daniel.karzel@coblox.tech>
Co-authored-by: Franck Royer <franck@coblox.tech>
@bors
Copy link
Contributor

bors bot commented Feb 1, 2020

Build succeeded

  • build (macos)
  • build (ubuntu)
  • build (windows)
  • e2e_test
  • static_analysis

@bors bors bot merged commit d72be3b into master Feb 1, 2020
@bors bors bot deleted the update-create-message branch February 1, 2020 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@D4nte D4nte D4nte approved these changes

Assignees

@da-kami da-kami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da-kami @D4nte @thomaseizinger