Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Use MakerNegotiator.getUrl(), remove steps for TakerNegotiator #407

Merged
merged 6 commits into from
Feb 1, 2020
Merged

Use MakerNegotiator.getUrl(), remove steps for TakerNegotiator #407

merged 6 commits into from
Feb 1, 2020

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Jan 30, 2020 •
edited
Loading

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2020

Are you sure the changelog does not need updating?

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2020

Are you sure the changelog does not need updating?

@D4nte D4nte mentioned this pull request Jan 31, 2020
Closed
@D4nte D4nte changed the title Use MakerNegotiator.getUrl() Use MakerNegotiator.getUrl(), remove steps for TakerNegotiator Jan 31, 2020
@D4nte D4nte marked this pull request as ready for review January 31, 2020 00:22
luckysori
luckysori approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some suggestions

create/new_project/examples/btc_eth/src/maker.ts Outdated Show resolved Hide resolved
create/new_project/examples/btc_eth/src/maker.ts Outdated Show resolved Hide resolved
create/new_project/examples/btc_eth/src/taker.ts Outdated Show resolved Hide resolved
@da-kami da-kami added the no-mergify Stop mergify to merge this automatically label Jan 31, 2020
@da-kami
Rephrase
3bfdb67 
Co-Authored-By: Daniel Karzel <daniel.karzel@coblox.tech>
@D4nte D4nte removed the no-mergify Stop mergify to merge this automatically label Jan 31, 2020
@D4nte
Copy link
Contributor Author

D4nte commented Jan 31, 2020

bors r+

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 31, 2020

Already running a review

@D4nte
Copy link
Contributor Author

D4nte commented Feb 1, 2020

bors retry

bors bot added a commit that referenced this pull request Feb 1, 2020
@bors
Merge #407
56c7ebc 
407: Use MakerNegotiator.getUrl(), remove steps for `TakerNegotiator` r=mergify[bot] a=D4nte

Resolves #371 and comit-network/comit-js-sdk#90.

Co-authored-by: Franck Royer <franck@coblox.tech>
@bors
Copy link
Contributor

bors bot commented Feb 1, 2020

Build succeeded

  • build (macos)
  • build (ubuntu)
  • build (windows)
  • e2e_test
  • static_analysis

@bors bors bot merged commit 3bfdb67 into master Feb 1, 2020
@bors bors bot deleted the 371-link-maker branch February 1, 2020 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luckysori luckysori luckysori approved these changes

@da-kami da-kami da-kami approved these changes

@bonomat bonomat Awaiting requested review from bonomat

Assignees

@D4nte D4nte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to maker is confusing
3 participants
@D4nte @da-kami @luckysori