-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init commit create react app with react-app-rewired #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
requested review from
luckysori and
thomaseizinger
and removed request for
luckysori
December 2, 2020 01:00
bonomat
force-pushed
the
react-bootstrap
branch
from
December 2, 2020 04:59
f4dbed3
to
6e8233e
Compare
bonomat
force-pushed
the
react-bootstrap
branch
2 times, most recently
from
December 2, 2020 21:34
5ac4280
to
e04a13a
Compare
waves: a react app wallet_lib: a rust/wasm lib used in waves bobtimus: a server exposing a simple API
bonomat
force-pushed
the
react-bootstrap
branch
from
December 3, 2020 00:10
daf106a
to
3c7b691
Compare
bonomat
commented
Dec 3, 2020
bonomat
force-pushed
the
react-bootstrap
branch
2 times, most recently
from
December 3, 2020 04:12
56d11c0
to
13238d5
Compare
bonomat
force-pushed
the
react-bootstrap
branch
from
December 3, 2020 04:40
d8c1dd5
to
8d29dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #12 do to changes of master
What is this?
This adds a new
waves
folder which is a react app using a rust wasm library combined with webpack.my-app
was creating using create-react-app.However, this would not let us configure webpack (which is the reason we went for create-react-app in the first place).
Hence we use
react-app-rewired
and created aconfig-override.js
The library
wasm_lib
was created usingwasm-pack new
.It showcases a single method to return hello world and a function to initialize a logger.
Issues
So far I like the setup, it has one caveat though: if we want to add
native
as a dependency inpackage.toml
then a rebuild is not automatically reloaded. File-based import work though.How to
Go into
my-app
and typefollowed by
to start in development mode. You can then make changes in the rust library under
native
and the code should automatically rebuild and reload.Enjoy :)