Do magic with the modelling wand #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole commitment is 33 bytes long with the last 32 bytes being the x-coordinate of the public key.
The original asset commitment can always be retrieved from the ConfidentalTxOut.
That is, most important to least important with increasing level of detail based on the order you encounter the structs as you read through the existing type definitions. Order of `impl` blocks for traits are at the bottom but unsorted.
Be gone, wild byte arrays! cc @da-kami
By providing two constructors for a ConfidentialTxOut, we can make it easier for users to properly construct a valid transaction that follows all the invariants that need to be upheld.
This also simplifies the calling site massively because we don't have to iterate over the inputs several times.
We always pass random bytes in here, I think this is just used for entropy.
We try to hide the actual wally APIs from the user by providing meaningfully named functions on the actual types that we want to construct.
luckysori
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We swing the magic modelling wand and produce two constructors on
TxOutthat make it a lot easier to produce valid transactions!