Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh monero monitoring wallet at startup to ensure daemon is is av… #1436

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Refresh monero monitoring wallet at startup to ensure daemon is is av… #1436

merged 1 commit into from
Aug 31, 2023

Conversation

binarybaron
Copy link
Collaborator

…ailable

delta1
delta1 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Aug 31, 2023
@bors @binarybaron
Merge #1436
d6bdc0d 
1436: Refresh monero monitoring wallet at startup to ensure daemon is is av… r=delta1 a=binarybaron

…ailable

Co-authored-by: binarybaron <86064887+binarybaron@users.noreply.github.com>
@binarybaron
Copy link
Collaborator Author

We have to revert this. I don't know if this takes forever if we have a lots of blocks to scan (we haven't used the CLI in a while) and I think we can make this more efficient as the wallet doesn't contain any transactions (99% sure) and is only used to watch the tx transfer proof

@bors
Copy link
Contributor

bors bot commented Aug 31, 2023

Build failed:

@delta1
Copy link
Collaborator

delta1 commented Aug 31, 2023

bors retry

bors bot added a commit that referenced this pull request Aug 31, 2023
@bors @binarybaron
Merge #1436
64b0c6b 
1436: Refresh monero monitoring wallet at startup to ensure daemon is is av… r=delta1 a=binarybaron

…ailable

Co-authored-by: binarybaron <86064887+binarybaron@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2023

Build failed:

@delta1
Copy link
Collaborator

delta1 commented Aug 31, 2023

bors retry

bors bot added a commit that referenced this pull request Aug 31, 2023
@bors @binarybaron
Merge #1436
6d212c3 
1436: Refresh monero monitoring wallet at startup to ensure daemon is is av… r=delta1 a=binarybaron

…ailable

Co-authored-by: binarybaron <86064887+binarybaron@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2023

Build failed:

@delta1
Copy link
Collaborator

delta1 commented Aug 31, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 31, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a34c112 into master Aug 31, 2023
10 of 23 checks passed
@bors bors bot deleted the check-daemon-monero branch August 31, 2023 12:20
@binarybaron binarybaron mentioned this pull request Sep 1, 2023
Merged
bors bot added a commit that referenced this pull request Sep 1, 2023
@bors @binarybaron
Merge #1438
5b16236 
1438: Revert "Refresh monero monitoring wallet at startup to ensure daemon is is av…" r=binarybaron a=binarybaron

Reverts #1436

Co-authored-by: binarybaron <86064887+binarybaron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binarybaron @delta1