Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump pem to 3.0 #1450

Merged
merged 1 commit into from
Oct 23, 2023
Merged

build(deps): bump pem to 3.0 #1450

merged 1 commit into from
Oct 23, 2023

Conversation

delta1
Copy link
Collaborator

@delta1 delta1 commented Oct 23, 2023

replaces #1415

also fixes the seed_from_pem_fails_for_long_seed unit test, which was "passing" but not actually testing what it meant to.

@delta1
build(deps): bump pem to 3.0
dcf9f24 
replaces comit-network#1415

also fixes the `seed_from_pem_fails_for_long_seed` unit test, which was
"passing" but not actually testing what it meant to.
delta1
delta1 commented Oct 23, 2023
View reviewed changes
Copy link
Collaborator Author

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d6c1353 into comit-network:master Oct 23, 2023
24 checks passed
@delta1 delta1 deleted the pem branch October 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@delta1