Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deadzone parameters for pathplanner #2

Closed
wants to merge 1 commit into from
Closed

Add deadzone parameters for pathplanner #2

wants to merge 1 commit into from

Conversation

Gernby
Copy link

@Gernby Gernby commented Jun 14, 2019

This is related to another PR I'll be submitting later today.

@Gernby
Add deadzone parameters for pathplanner
1740f08 
This is related to another PR I'll be submitting later today.
@geohot
Copy link
Collaborator

geohot commented Jun 15, 2019

So I looked at the other PR, it has cereal changes besides this. Also, comments and more description for me to be able to intelligently respond! "This is related to another PR I'll be submitting later today." isn't a description.

@Gernby
Copy link
Author

Gernby commented Jun 16, 2019

Thanks for the response. I actually need to close this PR, since I closed the related PR. However, I'm still a bit unsure about the purpose or goal of submitting cereal parameters separately in this repo. It seems that the only benefit of this being separate would be to improve Comma's data processing from custom forks. If so, then it seems that the requirements for new parameters should be pretty light, with quick turn-around time. If a new parameter requires detailed justification with supporting data, then it seems that this repo just increases effort for everyone.

@geohot geohot closed this Jun 27, 2019
krkeegan pushed a commit to krkeegan/cereal that referenced this pull request Oct 20, 2021
@sshane
add startupZss event (commaai#2)
9de6cd3
devtekve pushed a commit to devtekve/cereal that referenced this pull request Oct 12, 2023
@sunnyhaibin
MSPA (commaai#2)
318da0b 
* Cereal: Use custom reserved structs

* LongitudinalPersonality

* sync with upstream

* LongitudinalPersonalitySP defined

* rearrange

* no more
0312birdzhang pushed a commit to orapilot/cereal that referenced this pull request Dec 4, 2023
@MankaranSingh
Merge pull request commaai#2 from flowdriveai/feat_uploader
556ac79 
add stubs for UploaderState
@deanlee deanlee mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gernby @geohot