Visionbuf: refactor ion_fd to struct IonFileHandle #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
visionbuf_improve_iconfd
branch
from
4960584
to
87c3ab9
Compare
deanlee
force-pushed
the
visionbuf_improve_iconfd
branch
from
87c3ab9
to
8ce156a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ion_init(), refactor ion_fd to struct IonFileHandle to fix 2 issues:
ion_init()is not thread safe, ion_fd may be opened multiple times. (allocatecan be called in multiple threads, e.g. v4l_encoder), This may cause the client to use a different ion_fd for subsequent ioctl than the one used for ION_IOC_ALLOC