Route card redesign #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployed preview: https://35.connect-d5y.pages.devWelcome to new-connect! Make sure to:
Mobile
Desktop
|
|
Can you rebase to get the new preview screenshots? |
incognitojam
force-pushed
the
route-card-redesign
branch
from
15b87fe to
d9327e0
Compare
incognitojam
force-pushed
the
route-card-redesign
branch
from
d9327e0 to
d6f85fd
Compare
incognitojam
requested changes
Jul 6, 2024
adeebshihadeh
requested changes
Jul 11, 2024
src/components/RouteCard.tsx
Outdated
| const subhead = () => `${startTime().format('h:mm A')} to ${endTime().format('h:mm A')}` | ||
| const RouteHeader = (props: { route?: RouteSegments }) => { | ||
|
|
||
| const startTime = () => props?.route?.segment_start_times ? dayjs(props.route.segment_start_times[0]) : null |
There was a problem hiding this comment.
it's best not to add new usages of segment_start_times: #53
src/components/RouteCard.tsx
Outdated
| const RouteHeader = (props: { route?: RouteSegments }) => { | ||
|
|
||
| const startTime = () => props?.route?.segment_start_times ? dayjs(props.route.segment_start_times[0]) : null | ||
| const endTime = () => props?.route?.segment_end_times ? dayjs(props.route.segment_end_times.at(-1)) : null |
There was a problem hiding this comment.
same here with segment_end_times
src/types.d.ts
Outdated
| end_lat?: number | ||
| end_lng?: number | ||
| end_time?: string | ||
| fullname: string | ||
| end_time: string |
There was a problem hiding this comment.
this might not exist: #60
src/types.d.ts
Outdated
| end_time?: string | ||
| fullname: string | ||
| end_time: string | ||
| fullname?: string |
There was a problem hiding this comment.
this is guaranteed to exist
Reduces from ~8s to ~2s
|
Linter's failing |
yeah, it's because of the switch from segment_times to create_time. I posted a question for a potential fix on discord. |
|
Can you fix the merge conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
route card redesign based on David California's Figma