fine inside

commaai · Jul 14, 2023 · 66564a4 · 66564a4
1 parent 617d816
commit 66564a4
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/can/packer.cc b/can/packer.cc
@@ -59,11 +59,13 @@ std::vector<uint8_t> CANPacker::pack(uint32_t address, const std::vector<SignalP
 
   // For signals with offsets, leaving bytes at zero results in non-zero parsed values.
   // Require those signals to be explicitly set
-  for (const auto& dbc_signal : msg_it->second.sigs) {
-    if (dbc_signal.offset != 0 && enforce_checks) {
-      auto sig_it = std::find_if(values.begin(), values.end(), [&dbc_signal](const SignalPackValue& spv) { return spv.name == dbc_signal.name; });
-      if (sig_it == values.end()) {
-        throw std::runtime_error("CANPacker::pack(): missing signal with non-zero offset: " + dbc_signal.name + " in address " + std::to_string(address));
+  if (enforce_checks) {
+    for (const auto& dbc_signal : msg_it->second.sigs) {
+      if (dbc_signal.offset != 0) {
+        auto sig_it = std::find_if(values.begin(), values.end(), [&dbc_signal](const SignalPackValue& spv) { return spv.name == dbc_signal.name; });
+        if (sig_it == values.end()) {
+          throw std::runtime_error("CANPacker::pack(): missing signal with non-zero offset: " + dbc_signal.name + " in address " + std::to_string(address));
+        }
       }
     }
   }