-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honda: check regen paddle #1100
Comments
We will want to add this signal to panda safety/Honda carstate. Check out safety_gm.h and gm/carstate.py for reference. Let us know if you plan on adding this! |
I can! I'll fork OP and give it a shot.
…On Thu, Nov 30, 2023, 11:39 PM Shane Smiskol ***@***.***> wrote:
We will want to add this signal to panda safety/Honda carstate. Check out
safety_gm.h
<https://github.com/commaai/panda/blob/892ca5a0f19c07a4786373e360027ab6ec57f723/board/safety/safety_gm.h#L124-L126>
and gm/carstate.py
<https://github.com/commaai/openpilot/blob/e687be939e7cf67c4a75b87320ab058941d4316f/selfdrive/car/gm/carstate.py#L72-L74>
for reference.
Let us know if you plan on adding this!
—
Reply to this email directly, view it on GitHub
<#1100>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCPBBGJ3YKOFC64KZKKC6DYHFNQZAVCNFSM6AAAAABABKVL36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGQ2DOMBUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Need any direction to get started? |
Kinda. Unfortunately I haven't had time to start work on this (I'm in
Eastern time but I work UTC hours, so I'm a bit of a zombie right now).
Is there documentation on the "standard OP libraries) anywhere?
…On Thu, Dec 7, 2023, 14:15 Shane Smiskol ***@***.***> wrote:
Need any direction to get started?
—
Reply to this email directly, view it on GitHub
<#1100>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCPBBA3LI2H3SLXZBLXBNDYIIIVVAVCNFSM6AAAAABABKVL36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVHE2TQMBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
So the goal here to detect when the regen paddle has been pressed, to both know that stock cruise disengaging is okay so we don't flash a red alert, as well as implementing our own safety that enforces openpilot disengages at the same time (even if not using stock ACC) since this is like pressing the brake. To do this, we need to have openpilot understand that this signal exists and what it does (by setting regenPaddle in carstate.py), as well as in panda to enforce this behavior. Our abstractions should be pretty good for these types of changes, you just need to set this signal in both places. Finding the signal might be a different, smaller project. Cabana is helpful for reverse engineering CAN messages. Is there any specific questions you had? |
No, sir, that is exactly what I needed to know - thank you very much. I
triggered the behavior a bunch of times in past drives in order to find the
signal - unfortunately, I'm getting segfaults when loading videos in
Cabana, but I'm able to work past this (the warning banners still show in
the Cabana UI).
…On Tue, Dec 12, 2023 at 4:43 AM Shane Smiskol ***@***.***> wrote:
So the goal here to detect when the regen paddle has been pressed, to both
know that stock cruise disengaging is okay, as well as implementing our own
safety that enforces openpilot disengages at the same time (even if not
using stock ACC).
To do this, we need to have openpilot understand that this exists and what
it does (setting regenPaddle in carstate.py
<https://github.com/commaai/openpilot/blob/e687be939e7cf67c4a75b87320ab058941d4316f/selfdrive/car/gm/carstate.py#L72-L74>),
as well as in panda
<https://github.com/commaai/panda/blob/892ca5a0f19c07a4786373e360027ab6ec57f723/board/safety/safety_gm.h#L124-L126>
to enforce this safety behavior.
Our abstractions should be pretty good for these types of changes, you
just need to set this signal in both places. Finding the signal might be a
different, smaller project. Cabana
<https://github.com/commaai/openpilot/tree/master/tools/cabana> is
helpful to reverse engineer CAN messages.
Is there any specific questions you had?
—
Reply to this email directly, view it on GitHub
<#1100>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCPBBD4R5QICXLZSSQIFWTYJARMXAVCNFSM6AAAAABABKVL36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGY3DMMBXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@plygrnd let me know if there's any issues moving forward. |
Describe the bug
TL;DR
Honda Insight's brake regen adjustment paddles cause OP to throw a CruiseDisabled error instead of canceling cruise control.
More Info
The Honda Insight has adjustable regenerative braking. This is controlled by paddles on the steering wheel. Hitting either paddle when cruise is engaged will disengage cruise.
Disengaging cruise control in this fashion causes OP to trigger a "cruise not engaged" message and sound the alarm, instead of gracefully exiting cruise control via the "Cancel" button. This is governed in the Honda interface, L332.
It appears that the car sends a generic "Cruise Control disabled" message; there's a lot of junk in Cabana for this trip which isn't mapped to any signals, but one of those could be the issue.
Desired Outcome
When using the steering wheel paddles to disable cruise control, OP should treat this as a standard disablement instead of an emergency.
Which car does this affect?
Honda Insight EX 2019
Provide a route where the issue occurs
8958942b212e8cd9|2023-11-30--08-18-06--10
openpilot version
On
release3
, latest release.Additional info
No response
The text was updated successfully, but these errors were encountered: