Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda: check regen paddle #1100

Open
plygrnd opened this issue Nov 30, 2023 · 7 comments
Open

Honda: check regen paddle #1100

plygrnd opened this issue Nov 30, 2023 · 7 comments
Labels
bug car related to opendbc/car/ honda

Comments

@plygrnd
Copy link

plygrnd commented Nov 30, 2023

Describe the bug

TL;DR

Honda Insight's brake regen adjustment paddles cause OP to throw a CruiseDisabled error instead of canceling cruise control.

More Info

The Honda Insight has adjustable regenerative braking. This is controlled by paddles on the steering wheel. Hitting either paddle when cruise is engaged will disengage cruise.

Disengaging cruise control in this fashion causes OP to trigger a "cruise not engaged" message and sound the alarm, instead of gracefully exiting cruise control via the "Cancel" button. This is governed in the Honda interface, L332.

It appears that the car sends a generic "Cruise Control disabled" message; there's a lot of junk in Cabana for this trip which isn't mapped to any signals, but one of those could be the issue.

Desired Outcome

When using the steering wheel paddles to disable cruise control, OP should treat this as a standard disablement instead of an emergency.

Which car does this affect?

Honda Insight EX 2019

Provide a route where the issue occurs

8958942b212e8cd9|2023-11-30--08-18-06--10

openpilot version

On release3, latest release.

Additional info

No response

@plygrnd plygrnd added bug car related to opendbc/car/ labels Nov 30, 2023
@sshane
Copy link
Contributor

sshane commented Dec 1, 2023

We will want to add this signal to panda safety/Honda carstate. Check out safety_gm.h and gm/carstate.py for reference.

Let us know if you plan on adding this!

@sshane sshane added the honda label Dec 1, 2023
@sshane sshane changed the title Honda Insight control mapping Honda: check regen paddle Dec 1, 2023
@plygrnd
Copy link
Author

plygrnd commented Dec 1, 2023 via email

@sshane
Copy link
Contributor

sshane commented Dec 7, 2023

Need any direction to get started?

@plygrnd
Copy link
Author

plygrnd commented Dec 7, 2023 via email

@sshane
Copy link
Contributor

sshane commented Dec 12, 2023

So the goal here to detect when the regen paddle has been pressed, to both know that stock cruise disengaging is okay so we don't flash a red alert, as well as implementing our own safety that enforces openpilot disengages at the same time (even if not using stock ACC) since this is like pressing the brake.

To do this, we need to have openpilot understand that this signal exists and what it does (by setting regenPaddle in carstate.py), as well as in panda to enforce this behavior.

Our abstractions should be pretty good for these types of changes, you just need to set this signal in both places. Finding the signal might be a different, smaller project. Cabana is helpful for reverse engineering CAN messages.

Is there any specific questions you had?

@plygrnd
Copy link
Author

plygrnd commented Dec 12, 2023 via email

@sshane
Copy link
Contributor

sshane commented Jan 3, 2024

@plygrnd let me know if there's any issues moving forward.

@sshane sshane transferred this issue from commaai/openpilot Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car related to opendbc/car/ honda
Projects
None yet
Development

No branches or pull requests

2 participants