Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VW MQB: Added unittests for CRC calculation #1235

Merged
merged 13 commits into from
Sep 12, 2024
Merged

VW MQB: Added unittests for CRC calculation #1235

merged 13 commits into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. VW MQB: Added unittests for CRC calculation 

    Some of the messages are either missing fields that causes serialization to skip bits
or CRC/BZ fields aren't picked up by packers leading to invalid values.
    @JaCzekanski
    JaCzekanski committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a2082df View commit details
    Browse the repository at this point in the history

  2. VW MQB: Add missing fields in Getriebe_11 

    Test case is reenabled and now passes
    @JaCzekanski
    JaCzekanski committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7183393 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'master' of https://github.com/commaai/opendbc into vw-m… 

    …qb-crc-tests
    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fcfcd13 View commit details
    Browse the repository at this point in the history

  2. EV_Gearshift -> Motor_EV_01, enable test

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    23dc848 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/commaai/opendbc into vw-m… 

    …qb-crc-tests
    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    397ab8c View commit details
    Browse the repository at this point in the history

  4. skip Getribe_11 testing with a note about why

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b3c50b8 View commit details
    Browse the repository at this point in the history

  5. reenable all others, except SWA_01

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0ed131a View commit details
    Browse the repository at this point in the history

  6. turns out we can still test Getriebe_11

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    94310b7 View commit details
    Browse the repository at this point in the history

  7. New test data for SWA_01, re-enable test

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    95c7ba5 View commit details
    Browse the repository at this point in the history

  8. no longer a need for test skipping

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1269a7b View commit details
    Browse the repository at this point in the history

  9. no longer a need for custom tests

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    499ea2a View commit details
    Browse the repository at this point in the history

  10. more concise

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    786bf00 View commit details
    Browse the repository at this point in the history

  11. prefix with VW for clarity

    @jyoung8607
    jyoung8607 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f7f1430 View commit details
    Browse the repository at this point in the history