-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCA Giorgio: Alfa Romeo Stelvio #1251
Draft
jyoung8607
wants to merge
16
commits into
commaai:master
Choose a base branch
from
jyoung8607:fca-giorgio-port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+277
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Sep 18, 2024
This reverts commit 8790b93.
2 tasks
Jeep Renegade almost works on this port, we'll see what happens after some tweaks and updates. Renegade is derived from the Fiat SCCS Wide platform which has quite a lot of heritage predating the FCA merger. May end up renaming the port/safety to Fiat if this works out, we'll have to see how UDS fingerprinting looks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resuming work on commaai/openpilot#32898.
Users have driven an earlier version of this code on both Stelvio and Giulia and seem to be loving it. The lateral acceleration torque controller feed-forward is an excellent match for these cars. There are some obstacles we need to solve for official support; it's possible we'll have to ship it in dashcam mode.
Checklist
TBD
TBD
To-Do