Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: pitch compensate new long tune #1260

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Sep 20, 2024

Follow up to #1248. Only for positive accel (given pitch). Now doesn't apply too much gas going down hills, or too little going up them.

Lexus ES TSS2 routes:

This branch:
Downhill with PCM + pitch compensation: https://connect.comma.ai/57048cfce01d9625/00000123--c1523da2eb
Uphill with PCM + pitch compensation: https://connect.comma.ai/57048cfce01d9625/00000124--db7c9676fb

Current master:
Downhill with PCM compensation: https://connect.comma.ai/57048cfce01d9625/00000125--1231d30430
Uphill with PCM compensation: https://connect.comma.ai/57048cfce01d9625/00000126--47613d0ae6

@github-actions github-actions bot added car related to opendbc/car/ toyota labels Sep 20, 2024
@sshane
Copy link
Contributor Author

sshane commented Sep 20, 2024

Report looks like a success! On uphills, integral (seen in actuators.accel) does not need to wind up as high to achieve the same longitudinal acceleration:

This branch is on the right.

image

Same with start from stop, the compensation knows to go higher immediately, resulting in less integral windup:

image

As well as the creep test:

image


Now for the downhill plots. There's not much difference in the "start from stop" test, if any, but the creep test shows noticeably less overshoot:

image

And the gas step response shows the compensation requesting less acceleration and slightly less overshoot:

image


Reports:
LEXUS_ES_TSS2_57048cfce01d9625_0000012.zip

@sshane sshane merged commit 71aa716 into master Sep 20, 2024
5 checks passed
@sshane sshane deleted the pitch-comp-toyota-accel branch September 20, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ enhancement toyota
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant