Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ford: group similar coverage range measurements #1417

Closed
wants to merge 3 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 24, 2024

Increases rate of points from ~8Hz to ~16Hz, but decreases points by half

@github-actions github-actions bot added car related to opendbc/car/ ford labels Oct 24, 2024
@sshane
Copy link
Contributor Author

sshane commented Oct 24, 2024

Combining the two measurements from each Doppler coverage scan doubles the update frequency of each radar point from ~8 Hz to ~16 Hz, which is seen clearly in the liveTracks messages. radard functionality should remain roughly the same as it was using the other duplicate radar point for each scan mode

image

@sshane
Copy link
Contributor Author

sshane commented Oct 24, 2024

I noticed that Ford's radar parser often deletes and re-creates tracks due to some switching logic we have. radard doesn't handle this well, as aLeadK is calculated on a per-track basis, so it's nearly always zero, causing the planner to not react well to heavily braking leads.

This PR only exacerbates this problem, best to track each scan mode's points individually since it helps reduce track switching and I will check the CPU usage.

@sshane sshane closed this Oct 24, 2024
@sshane sshane deleted the ford-group-similar-range-coverages branch October 24, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ ford
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant