Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Dbcs with scons #1519

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

LouisVelez
Copy link
Contributor

@LouisVelez LouisVelez commented Nov 22, 2024

  1. Removes generated dbcs and adds gitignore
  2. Builds dbcs with scons
    resolves Build generated DBCs with SCons #1309

@LouisVelez LouisVelez marked this pull request as ready for review November 22, 2024 18:09
@adeebshihadeh
Copy link
Contributor

Nice job keeping this minimal!

Not sure what's up with the CI flakiness. Want to look into that?

@adeebshihadeh adeebshihadeh merged commit 551081b into commaai:master Nov 22, 2024
3 of 4 checks passed
@LouisVelez
Copy link
Contributor Author

@adeebshihadeh, after analyzing the logs, it seems the job timeout of 1 minute was triggered because the runners didn't register with enough time left.

  • Ubuntu Runner: Registered at 18:08:42. No issues here.
  • Mac Runner: Registered at 18:09:33 (50s after Ubuntu), with a timeout request at 18:09:41 (8s later).
  • Static Runner: Registered at 18:09:34 (51s after Ubuntu), with a timeout request at 18:09:46 (12 seconds later). Similarly affected.

Do we want to increase the timeout to 2m?

@LouisVelez LouisVelez deleted the dbcs-with-scons branch November 22, 2024 20:31
@adeebshihadeh
Copy link
Contributor

I really wanted to keep the timeout at 1m... but it might not be possible.

@maxime-desroches can you decide what to do here?

@sshane
Copy link
Contributor

sshane commented Nov 22, 2024

don't forget the openpilot side of this! getting missing DBC errors and it's not building them

This was referenced Nov 22, 2024
@maxime-desroches
Copy link
Contributor

I confirmed that the timeout includes the time for the runner to pick up the job. A solution to still fail if the whole workflow takes more than 1 minutes would be to do something like this with composite actions:

    - uses: commaai/opendbc/timeout@master
    - name: job 1
      timeout-minutes: 1
      run: ...
    - name: job 2
      timeout-minutes: 1
      run: ...
    - uses: commaai/opendbc/timeout@master

The only downside is that the workflow would fail after having completed the jobs

@sshane
Copy link
Contributor

sshane commented Nov 23, 2024

The output_files is missing many generated files inside the brand folders generated from the Python files, so caching doesn't work with this.

@LouisVelez can you make sure that tesla_radar_bosch.dbc, tesla_radar_continental.dbc, hyundai_kia_mando_corner_radar.dbc, and hyundai_kia_mando_front_radar.dbc are included so they can be cleaned up/pulled from cached properly?

https://github.com/commaai/openpilot/actions/runs/11983606559/job/33413369982?pr=34088

image

@sshane sshane mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build generated DBCs with SCons
4 participants