-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Dbcs with scons #1519
Build Dbcs with scons #1519
Conversation
Nice job keeping this minimal! Not sure what's up with the CI flakiness. Want to look into that? |
@adeebshihadeh, after analyzing the logs, it seems the job timeout of 1 minute was triggered because the runners didn't register with enough time left.
Do we want to increase the timeout to 2m? |
I really wanted to keep the timeout at 1m... but it might not be possible. @maxime-desroches can you decide what to do here? |
don't forget the openpilot side of this! getting missing DBC errors and it's not building them |
I confirmed that the timeout includes the time for the runner to pick up the job. A solution to still fail if the whole workflow takes more than 1 minutes would be to do something like this with composite actions:
The only downside is that the workflow would fail after having completed the jobs |
The @LouisVelez can you make sure that https://github.com/commaai/openpilot/actions/runs/11983606559/job/33413369982?pr=34088 |
resolves Build generated DBCs with SCons #1309