Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HKG: ALT_LAMPS support #1593

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

HKG: ALT_LAMPS support #1593

wants to merge 1 commit into from

Conversation

ccdunder
Copy link

@ccdunder ccdunder commented Dec 19, 2024 •
edited
Loading

Without this, turn signals aren't detected for a number of new cars.

Related:

TODO:

  • make it consistent with codebase conventions
    • too pythonic
  • discuss whether we want the flag to be purely dynamic.
    • if yes, verify expected behavior on existing cars e.g. all test routes (w/ and w/o ALT_LAMP)
    • if no, add static flag to gate feature

@ccdunder
Fix lane change detection when ALT_LAMPS are used.
00f2641 
This is needed for the Kia Caravan '25.
@ccdunder ccdunder marked this pull request as draft December 19, 2024 19:58
@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Dec 19, 2024
@ccdunder ccdunder changed the title Fix lane change detection when ALT_LAMPS are used. HKG: Fix lane change detection when ALT_LAMPS are used. Dec 19, 2024
@ccdunder ccdunder changed the title HKG: Fix lane change detection when ALT_LAMPS are used. HKG: ALT_LAMPS support Dec 19, 2024
@ccdunder ccdunder mentioned this pull request Dec 19, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car related to opendbc/car/ hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ccdunder