Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: HDA2 ALT_BUTTON support #1594

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ccdunder
Copy link

Without this, HDA2 cars w/ ALT_BUTTONs throw a CAN error on start, and won't resume from standstill.

This is needed for 2025 Kia Caravan.

Dependencies:

TODO:

  • Check if/what other car ports that need this.

This is necessary in order to support the 2025 Kia Carnival w/ HDA2,
which uses ALT_BUTTONS.

This seems exceedingly unlikely to cause a regression. If any car wasn't
hitting this branch and now does, it means it was already broken (trying
to use BUTTONS when they don't exist).
This is needed for the Kia Caravan '25.
@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant