Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CANParser: process all signals before updating values #977

Merged
merged 11 commits into from
Nov 22, 2023
Merged

CANParser: process all signals before updating values #977

merged 11 commits into from
Nov 22, 2023

Commits on Nov 18, 2023

  1. process all signals before ending early

    @sshane
    sshane committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3e9a27c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. this is more clear

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    de31c64 View commit details
    Browse the repository at this point in the history

  2. this is more clear

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    75511ec View commit details
    Browse the repository at this point in the history

  3. Revert "this is more clear" 

    This reverts commit 75511ec.
    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    feb2989 View commit details
    Browse the repository at this point in the history

  4. test!

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    4d34865 View commit details
    Browse the repository at this point in the history

  5. comment

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1182d6e View commit details
    Browse the repository at this point in the history

  6. it would return false if any checksum or counter was invalid, not upd… 

    …ating last_seen_nanos, so don't change behavior
    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7759ccf View commit details
    Browse the repository at this point in the history

  7. we can do this, but I don't like how it's reliant on last_seen_nanos … 

    …(not explicit) to not break
    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    05b3293 View commit details
    Browse the repository at this point in the history

  8. back to sanity

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d490b96 View commit details
    Browse the repository at this point in the history

  9. cmt

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3925f56 View commit details
    Browse the repository at this point in the history

  10. rename

    @sshane
    sshane committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    cd3be50 View commit details
    Browse the repository at this point in the history