Skip to content

Commit

Permalink
Always send loud alert when cruise disables
Browse files Browse the repository at this point in the history
For users without the pedal there are sometimes instances where
1.  the car brakes because lead car is slowing, 
2.  the car falls below the minimum cruise threshold and cruise disables
3.  the lead car pulls away
4.  car is now below cruise so can't accelerate, the non-loud alert is displayed and OP is disabled - the user doesn't notice
5.  the lead car brakes
6.  the user is caught flat footed because they weren't aware that step 4 happened because couldn't hear / see the subtle alert that OP was disabled

This is a safety concern as it happened to me a few times before I got my pedal.  Sending the loud alert mitigates this risk.
  • Loading branch information
NeonGalaxy75 authored Dec 16, 2018
1 parent e3c934b commit 654abc4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions selfdrive/car/honda/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,10 +543,8 @@ def update(self, c):
# it can happen that car cruise disables while comma system is enabled: need to
# keep braking if needed or if the speed is very low
if self.CP.enableCruise and not ret.cruiseState.enabled and c.actuators.brake <= 0.:
# non loud alert if cruise disbales below 25mph as expected (+ a little margin)
# send loud alert if cruise disables below 25mph as expected (+ a little margin)
if ret.vEgo < self.CP.minEnableSpeed + 2.:
events.append(create_event('speedTooLow', [ET.IMMEDIATE_DISABLE]))
else:
events.append(create_event("cruiseDisabled", [ET.IMMEDIATE_DISABLE]))
if self.CS.CP.minEnableSpeed > 0 and ret.vEgo < 0.001:
events.append(create_event('manualRestart', [ET.WARNING]))
Expand Down

0 comments on commit 654abc4

Please sign in to comment.