Skip to content

Commit

Permalink
process replay: handle inf and nan in absolute tolerance
Browse files Browse the repository at this point in the history
  • Loading branch information
adeebshihadeh committed Jan 12, 2022
1 parent 3816ecf commit 9941c99
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion selfdrive/test/process_replay/compare_logs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import bz2
import os
import sys
import math
import numbers
import dictdiffer
from collections import Counter
Expand Down Expand Up @@ -82,10 +83,12 @@ def compare_logs(log1, log2, ignore_fields=None, ignore_msgs=None, tolerance=Non
dd = dictdiffer.diff(msg1_dict, msg2_dict, ignore=ignore_fields)

# Dictdiffer only supports relative tolerance, we also want to check for absolute
# TODO: add this to dictdiffer
def outside_tolerance(diff):
if diff[0] == "change":
a, b = diff[2]
if isinstance(a, numbers.Number) and isinstance(b, numbers.Number):
finite = math.isfinite(a) and math.isfinite(b)
if finite and isinstance(a, numbers.Number) and isinstance(b, numbers.Number):
return abs(a - b) > max(tolerance, tolerance * max(abs(a), abs(b)))
return True

Expand Down

0 comments on commit 9941c99

Please sign in to comment.