Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP Long creeping with lead car stopped #23884

Closed
redacid95 opened this issue Mar 1, 2022 · 2 comments
Closed

OP Long creeping with lead car stopped #23884

redacid95 opened this issue Mar 1, 2022 · 2 comments
Labels
bug car vehicle-specific

Comments

@redacid95
Copy link
Contributor

redacid95 commented Mar 1, 2022

Describe the bug

When lead car comes to a stop, OP seems to react and come to a stop, but then start to creep forward even when lead car doesn't move. This happens almost every complete stop, regardless of the scene.

What hardware does this issue affect?

comma three

Provide a route where the issue occurs

f1055ddb93ff2d3b|2022-02-28--17-15-08--9

openpilot version

49eb4fb

Additional info

Additionally, I am on OP long on Honda Bosch. I understand this is experimental, so let me know if this is something that should be resolved with E2E.

I can also get more segments if required.

It appeared that this was being looked into here, however I tried these changes and still experienced the issue. #23838

@redacid95 redacid95 added the bug label Mar 1, 2022
@sshane
Copy link
Contributor

sshane commented Mar 2, 2022

It looks like the car just overshot the desired acceleration when it was reducing it coming to a stop, you can see the planner correctly commanding a stop. Integral was also wound up a bit, and proportional didn't have enough gain to command enough brake quick enough.

Screenshot from 2022-03-02 01-12-37

@sshane sshane added car bug and removed bug labels Mar 2, 2022
@pd0wm
Copy link
Contributor

pd0wm commented Mar 2, 2022

The issue could also come from vision only longitudinal, the lead distances/speeds aren't always self consistent for stopped cars. Closing this issue since it's not expected to work right now.

@pd0wm pd0wm closed this as completed Mar 2, 2022
@pd0wm pd0wm added bug car vehicle-specific and removed car bug labels Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific
Projects
None yet
Development

No branches or pull requests

3 participants