Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the creeping behavior in the first maneuver in
test_longitudinal.py
.I addressed this in this PR by modifying
get_safe_obstacle_distance
for small speeds.Below a certain speed, I chose
v_min = .5
the follow distance should not decrease further.Otherwise openpilot brakes and then wants to get closer since the desired distance gets smaller.
Plot:
Output of
test_longitudinal.py
Before this PR:
After this PR: