c++ replay: send frames based on custom encodeIdx packet #22364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
replay_eidx
branch
from
3579fbd
to
fa0ac99
Compare
|
there are no ROAD_ENCODE_IDX in the qlogs of demo_route and (a8e8bf6a3864361b|2021-01-04--03-01-18). I don't know why. |
|
They are present on more recent routes. It's fine if replay on qlog doesn't work with old routes. |
pd0wm
reviewed
Sep 29, 2021
| }; | ||
|
|
||
| kj::ArrayPtr<const capnp::word> words((const capnp::word *)raw_.data(), raw_.size() / sizeof(capnp::word)); | ||
| while (words.size() > 0) { | ||
| try { | ||
| std::unique_ptr<Event> evt = std::make_unique<Event>(words); | ||
| switch (evt->which) { | ||
| case cereal::Event::ROAD_CAMERA_STATE: |
There was a problem hiding this comment.
I don't think we need all this extra tracking of the camera state timestamp. In the rare cases that neither EOF or SOF are set we can just use the logMonoTime of the encode packet.
|
Also saw some weird skipping around, so decided to just steal your idea of a isCustomEvent flag on the event and apply it to the PR I already made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.