Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Car Port for 2022 Santa Fe Hybrid #22962

Merged

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Nov 18, 2021

Checklist

  • added to RELEASES, CARS
  • test route added to test_routes.py
  • route with openpilot: 37398f32561a23ad|2021-11-18--00-11-35
  • Harness Type: Hyundai L

Thanks to community Santa Fe Hybrid owner vijay2305.

@sunnyhaibin sunnyhaibin marked this pull request as ready for review November 18, 2021 06:35
@@ -12,7 +12,8 @@ class CarControllerParams:
def __init__(self, CP):
if CP.carFingerprint in [CAR.SONATA, CAR.PALISADE, CAR.SANTA_FE, CAR.VELOSTER, CAR.GENESIS_G70,
CAR.IONIQ_EV_2020, CAR.KIA_CEED, CAR.KIA_SELTOS, CAR.ELANTRA_2021,
CAR.ELANTRA_HEV_2021, CAR.SONATA_HYBRID, CAR.KONA_HEV, CAR.SANTA_FE_2022, CAR.KIA_K5_2021, CAR.KONA_EV, CAR.KONA, CAR.IONIQ_HEV_2022]:
CAR.ELANTRA_HEV_2021, CAR.SONATA_HYBRID, CAR.KONA_HEV, CAR.SANTA_FE_2022,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like all new cars should go here. want to submit a PR to blacklist the 255 cars?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like all new cars should go here. want to submit a PR to blacklist the 255 cars?

@adeebshihadeh Here's the PR with the blacklist! #23255

@adeebshihadeh adeebshihadeh changed the title Hyundai (HKG): Add Car Port for 2022 Santa Fe Hybrid Hyundai: Add Car Port for 2022 Santa Fe Hybrid Nov 19, 2021
@adeebshihadeh adeebshihadeh changed the title Hyundai: Add Car Port for 2022 Santa Fe Hybrid Hyundai: Car Port for 2022 Santa Fe Hybrid Nov 19, 2021
@adeebshihadeh adeebshihadeh merged commit 73d66ad into commaai:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants