Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mazda: alert when LKAS is disabled, a second attempt #23288

Merged
merged 7 commits into from
Jan 31, 2022
6 changes: 5 additions & 1 deletion selfdrive/car/mazda/carstate.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ def __init__(self, CP):
self.acc_active_last = False
self.low_speed_alert = False
self.lkas_allowed_speed = False
self.lkas_disabled = False

def update(self, cp, cp_cam):

Expand Down Expand Up @@ -91,9 +92,12 @@ def update(self, cp, cp_cam):

self.acc_active_last = ret.cruiseState.enabled

self.crz_btns_counter = cp.vl["CRZ_BTNS"]["CTR"]

# camera signals
self.lkas_disabled = cp_cam.vl["CAM_LANEINFO"]["LANE_LINES"] == 0
self.cam_lkas = cp_cam.vl["CAM_LKAS"]
self.cam_laneinfo = cp_cam.vl["CAM_LANEINFO"]
self.crz_btns_counter = cp.vl["CRZ_BTNS"]["CTR"]
ret.steerError = cp_cam.vl["CAM_LKAS"]["ERR_BIT_1"] == 1

return ret
Expand Down
4 changes: 3 additions & 1 deletion selfdrive/car/mazda/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ def update(self, c, can_strings):
# events
events = self.create_common_events(ret)

if self.CS.low_speed_alert:
if self.CS.lkas_disabled:
events.add(EventName.lkasDisabled)
elif self.CS.low_speed_alert:
events.add(EventName.belowSteerSpeed)

ret.events = events.to_msg()
Expand Down
7 changes: 5 additions & 2 deletions selfdrive/controls/lib/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,6 @@ def joystick_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool, sof

EventName.stockFcw: {},

EventName.lkasDisabled: {},

# ********** events only containing alerts displayed in all states **********

EventName.joystickDebug: {
Expand Down Expand Up @@ -823,4 +821,9 @@ def joystick_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool, sof
ET.NO_ENTRY: NoEntryAlert("Cruise Fault: Restart the Car"),
},

EventName.lkasDisabled: {
ET.PERMANENT: NormalPermanentAlert("LKAS Disabled: Enable LKAS to engage"),
ET.NO_ENTRY: NoEntryAlert("LKAS Disabled"),
},

}