PlotJuggler: Parse routes from connect #23320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
force-pushed
the
pj-parse-from-cabana
branch
2 times, most recently
from
8e46f93 to
1f7ce4e
Compare
sshane
changed the title
sshane
force-pushed
the
pj-parse-from-cabana
branch
from
1f7ce4e to
bc7b6b4
Compare
|
@adeebshihadeh What do you think of bringing over (part of) |
|
Ah, that's already in progress in this PR #23263 :). I'm closing this one. |
|
Ah didn't see that PR, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit easier to start inspecting data when copy/pasting a route name from comma connect. Instead of dealing with an inconspicuous error message and then manually fixing the route name for juggle.py, this PR parses the segment number correctly from the pasted string.