Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanePlanner: correct path offset for TICI #23329

Closed
wants to merge 5 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Dec 28, 2021

The model's path predictions are in the perspective of the EON/C2's left camera of -0.06 m, however with TICI it's treated as it's centered, but it should be offsetting the path extra 0.06 m to the right, this might be causing some minor left hugging.

Even if offsetting doesn't fully offset the path due to the model behaving unexpectedly with path offsets, since they were added at all I think getting it right is a good idea.

Or with the smaller offset are we sacrificing hugging for less path oscillation if the model behaves unexpectedly with path offsets?

@sshane sshane changed the title Calculate correct path offset for TICI LanePlanner: correct path offset for TICI Dec 28, 2021
leave the flippening to another PR
@pd0wm pd0wm added tuning controls controls/planner related and removed tuning labels Dec 28, 2021
@haraschax
Copy link
Contributor

I should have added comments to make this clear, but it is the way it is intended now. There are pretty complex effects at work. We look at the data from the model to see the average prediction difference between the model path from the TICI and C2 and that's how we get the current model path offsets.

Eventually we will input the camera offset into the model and it will all be a lot cleaner :).

@haraschax haraschax closed this Jan 3, 2022
@sshane sshane deleted the correct-path-offset branch January 3, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls controls/planner related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants