Kia Niro EV use regular Hyundai safety mode #23461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2020 Kia Niro EV is not a legacy car and outputs radar points without needing to run a script. Making the proposed changes enables OP Long to work perfectly with vision+radar.
pd0wm
changed the title
budney
added a commit
to budney/openpilot
that referenced
this pull request
Jan 14, 2022
7eca4d6 tools: better joystick instructions ed5e58c Hyundai: use regular Hyundai safety mode and add radar DBC (commaai#23461) 233a6e4 LanePlanner: offsets cleanup (commaai#23459) 24213ac lfs: easier to use config (commaai#23490) 6e817f9 manager: default driverview to False (commaai#23492) 44592f4 statsd: run at 2Hz (commaai#23493) 35ec6ac use ndarray.tolist to convert numpy array to float (commaai#23485) 8444f82 calibrationd: convert existing calibration to numpy (commaai#23494) 5fb9c6a thermald has slowly started to use more CPU 678732d AlertManager: cleanup add_many (commaai#23438) 85dcfbb update comment (commaai#23495) a186bcc cleanup iterate keys in dictionaries (commaai#23497) 79577e4 boardd: remove ublox timestamp logging (commaai#23498) dbae5e7 lateral_planner: use nympy.isnan().any() (commaai#23500) b1a226b VW MQB: Add FW for 2022 Volkswagen Atlas (commaai#23501) eb9f359 Toyota: Support Avalon 2022 (TSS2.5) (commaai#23381) 08a1ce0 update release notes 3816ecf bump opendbc 9941c99 process replay: handle inf and nan in absolute tolerance de572c3 calibrationd: fix indentation (commaai#23502) e5f9af4 calibrationd: Don't repeatedly call get_valid_idxs() (commaai#23473) f808b17 use roll std from locationd (commaai#23449) 7d7c0ff tools: add bootlog helpers (commaai#23504) ee52a61 add pre-commit hook for large files (commaai#23505) c214aee cleanup .gitattributes (commaai#23503) 9e1428f Do not disable loggerd when below 5% space (commaai#23440) 48b6dfa controlsd: check self.enabled out of the any() (commaai#23507) c84a085 bump cereal: more qlog decimation fcfea4c Kia Niro EV - replace \000 by \x00 (commaai#23509) 6d16b0c can_printer.py: default no ascii 1538013 pandad: only reset pandas on first run (commaai#23511) 6d5dce2 Subaru: fix missing commas in fingerprints (commaai#23512) 2c94f15 linter: don't allow implicitly concatenated strings (commaai#23513) d5f4fdb eliminate xx filereader (commaai#23514) 57156c4 Chrysler: remove standstill exception for gas disengage (commaai#23515) df35ebd fix filereader cd:/ replacement a6b46c3 filereader better name for cd:/ replacement 6dbae95 UI: reset interactivity timeout on PC (commaai#23508) 9f4fd73 Toyota: DBC signal renames (commaai#23452) fd042a5 controlsd: cleanup parsing android log (commaai#23421) feae375 swaglog.cc: add test case. fixed the ctx of the first message is empty (commaai#23226) 8c53adf swaglog: add daemon name to context (commaai#23518) 610b99f Log android system shutdown to param (commaai#23520) ef3a549 thermald: remove modem version log (commaai#23524) e72eb1d thermald: remove brightness setting on ui crash (commaai#23527) ed23177 thermald: remove panda disconnect logic (commaai#23526) 53ca036 thermald: let manager handle shutdown (commaai#23528) b75e410 boardd: panda_state_thread run closer to 2 Hz (commaai#23529) 785180d MainWindow::eventFilter: add static keyword for evts (commaai#23521) 75be122 ui/WifiManager: inherit from QObject instead of QWidget (commaai#23523) 39d904d ui/networking: combine connect functions into one (commaai#23522) 308a6f1 manager: log exit reason (commaai#23532)
budney
added a commit
to budney/openpilot
that referenced
this pull request
Mar 24, 2022
7eca4d6 tools: better joystick instructions ed5e58c Hyundai: use regular Hyundai safety mode and add radar DBC (commaai#23461) 233a6e4 LanePlanner: offsets cleanup (commaai#23459) 24213ac lfs: easier to use config (commaai#23490) 6e817f9 manager: default driverview to False (commaai#23492) 44592f4 statsd: run at 2Hz (commaai#23493) 35ec6ac use ndarray.tolist to convert numpy array to float (commaai#23485) 8444f82 calibrationd: convert existing calibration to numpy (commaai#23494) 5fb9c6a thermald has slowly started to use more CPU 678732d AlertManager: cleanup add_many (commaai#23438) 85dcfbb update comment (commaai#23495) a186bcc cleanup iterate keys in dictionaries (commaai#23497) 79577e4 boardd: remove ublox timestamp logging (commaai#23498) dbae5e7 lateral_planner: use nympy.isnan().any() (commaai#23500) b1a226b VW MQB: Add FW for 2022 Volkswagen Atlas (commaai#23501) eb9f359 Toyota: Support Avalon 2022 (TSS2.5) (commaai#23381) 08a1ce0 update release notes 3816ecf bump opendbc 9941c99 process replay: handle inf and nan in absolute tolerance de572c3 calibrationd: fix indentation (commaai#23502) e5f9af4 calibrationd: Don't repeatedly call get_valid_idxs() (commaai#23473) f808b17 use roll std from locationd (commaai#23449) 7d7c0ff tools: add bootlog helpers (commaai#23504) ee52a61 add pre-commit hook for large files (commaai#23505) c214aee cleanup .gitattributes (commaai#23503) 9e1428f Do not disable loggerd when below 5% space (commaai#23440) 48b6dfa controlsd: check self.enabled out of the any() (commaai#23507) c84a085 bump cereal: more qlog decimation fcfea4c Kia Niro EV - replace \000 by \x00 (commaai#23509) 6d16b0c can_printer.py: default no ascii 1538013 pandad: only reset pandas on first run (commaai#23511) 6d5dce2 Subaru: fix missing commas in fingerprints (commaai#23512) 2c94f15 linter: don't allow implicitly concatenated strings (commaai#23513) d5f4fdb eliminate xx filereader (commaai#23514) 57156c4 Chrysler: remove standstill exception for gas disengage (commaai#23515) df35ebd fix filereader cd:/ replacement a6b46c3 filereader better name for cd:/ replacement 6dbae95 UI: reset interactivity timeout on PC (commaai#23508) 9f4fd73 Toyota: DBC signal renames (commaai#23452) fd042a5 controlsd: cleanup parsing android log (commaai#23421) feae375 swaglog.cc: add test case. fixed the ctx of the first message is empty (commaai#23226) 8c53adf swaglog: add daemon name to context (commaai#23518) 610b99f Log android system shutdown to param (commaai#23520) ef3a549 thermald: remove modem version log (commaai#23524) e72eb1d thermald: remove brightness setting on ui crash (commaai#23527) ed23177 thermald: remove panda disconnect logic (commaai#23526) 53ca036 thermald: let manager handle shutdown (commaai#23528) b75e410 boardd: panda_state_thread run closer to 2 Hz (commaai#23529) 785180d MainWindow::eventFilter: add static keyword for evts (commaai#23521) 75be122 ui/WifiManager: inherit from QObject instead of QWidget (commaai#23523) 39d904d ui/networking: combine connect functions into one (commaai#23522) 308a6f1 manager: log exit reason (commaai#23532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description [The 2020 Kia Niro EV to my understanding is not a Hyundai Legacy car and works with OpenPilot Longitudinal. I removed CAR.KIA_NIRO_EV from the list of Hyundai legacy cars and I changed the dbc line for the Kia Niro EV to include 'hyundai_kia_mando_front_radar'. Following installation of the patched fork, I ssh into the device and ran "echo -n "1" > /data/params/d/DisableRadar_Allow" followed by "sudo reboot." I enabled the toggle for OpenPilot Longitudinal and rebooted the device.]
Verification [To verify the change worked, I went for a drive and where I enabled OP and followed cars. I could see the yellow arrow on screen when a car was ahead of me and that would turn to a yellow arrow with a red outline as I got closer. My car responded as it should slowing to a stop, and resuming as it should (~119s in route below). The route below should provide the evidence needed to show that OP Long worked. In Cabana it can be seen that OP long is controlling the car and that 50x radar track signals are present. ]
Route
Route: 74c8f75bdfbd84e7|2022-01-09--01-45-24--0