-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyundai: Car Port for 2022 Kona Electric Camera SCC #23517
Conversation
According to @sunnyhaibin, this car has no radar, with the camera sending the SCC messages, so panda safety may be required to enable openpilot longitudinal control |
After talk with @sunnyhaibin and looking at routes, some 2021 Kona Electrics have a radar, however the definitions and addresses are different, and the camera sends the SCC messages. The longitudinal safety should be the same as the 2022 Kanas, however we need to detect these different 2021 model year cars to use a different radar parser and not try to disable the radar. Hate to make a new platform for the same model year, what do you think @pd0wm? Edit: seems like the owner was mistaken with his 2021 Kona EV, got the VIN manually from him and a single VIN decoder site says it's a 2022 model year (KMHK381GUNU147696, dongle 1d6ecb67ec23a1b8), so this may be much simpler than we first thought. |
We will merge the car initially thought to be 2021 into this PR as we now believe that all these cars do have a radar but just for FCA and AEB (as seen in the radar FW version), then sunny will finish up the openpilot port and I'll help out with safety. If it turns out there's actually a difference (only thing would be the 2022's don't broadcast radar anywhere), then we can split out later |
a641f38
to
0926821
Compare
55fe62d
to
093a22d
Compare
@sshane User confirmed that button send from openpilot to resume from standstill works! 🎉
This port should be ready to merge. |
Can you have him test gas to disengage? |
Will do! User mentioned he will have it tested in the AM his time. |
@sshane |
@sunnyhaibin That route has no disengage on gas on. However the route you added to test_models does disengage on gas, so I'll check that. Seems to be working! |
* rm from ed882557605319f9 * rm from ffce4a1d578827ee * rm from 700d37ccd12315cf * can't find, but probably same * rm from 15755effe9d073b1 * rm from 5b7caafa7ec1a5cf * rm from ec07911a91f863f3 * rm from 7627c16a16a6f69b * rm from 007d5e4ad9f86d13 * rm from 06a3b9e474ce581d * rm from 22203eb8892a6f28 * rm from ff973b941a69366f * rm from 3ea622c3c0ec3055 * rm from #23517 * rm from b0e1cdf87262c7ad * old format FW version * rm from 54f0bbcb6527012e & 4cbcc16b655c1591 * test abs * format
* rm from ed882557605319f9 * rm from ffce4a1d578827ee * rm from 700d37ccd12315cf * can't find, but probably same * rm from 15755effe9d073b1 * rm from 5b7caafa7ec1a5cf * rm from ec07911a91f863f3 * rm from 7627c16a16a6f69b * rm from 007d5e4ad9f86d13 * rm from 06a3b9e474ce581d * rm from 22203eb8892a6f28 * rm from ff973b941a69366f * rm from 3ea622c3c0ec3055 * rm from commaai#23517 * rm from b0e1cdf87262c7ad * old format FW version * rm from 54f0bbcb6527012e & 4cbcc16b655c1591 * test abs * format
* rm from ed882557605319f9 * rm from ffce4a1d578827ee * rm from 700d37ccd12315cf * can't find, but probably same * rm from 15755effe9d073b1 * rm from 5b7caafa7ec1a5cf * rm from ec07911a91f863f3 * rm from 7627c16a16a6f69b * rm from 007d5e4ad9f86d13 * rm from 06a3b9e474ce581d * rm from 22203eb8892a6f28 * rm from ff973b941a69366f * rm from 3ea622c3c0ec3055 * rm from commaai/openpilot#23517 * rm from b0e1cdf87262c7ad * old format FW version * rm from 54f0bbcb6527012e & 4cbcc16b655c1591 * test abs * format old-commit-hash: bbd08ba
Checklist
1d6ecb67ec23a1b8|2022-06-12--17-53-09
ff973b941a69366f|2022-07-28--22-01-19
1d6ecb67ec23a1b8
248133d966e0182c
bcce6204298475be
ff973b941a69366f
Requires
Thanks to community Kona Electric 2022 owner Shfqrkhn, awesomebytes, and Zack1010OP.