Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Car Port for 2022 Kona Electric Camera SCC #23517

Merged
merged 32 commits into from
Aug 3, 2022

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Jan 14, 2022

Checklist

  • added to RELEASES, entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to test_routes.py
  • route with openpilot:
    • 1d6ecb67ec23a1b8|2022-06-12--17-53-09
    • ff973b941a69366f|2022-07-28--22-01-19
  • Harness Type:
  • Dongle IDs of the FW versions:
    • 1d6ecb67ec23a1b8
    • 248133d966e0182c
    • bcce6204298475be
    • ff973b941a69366f

Requires

Thanks to community Kona Electric 2022 owner Shfqrkhn, awesomebytes, and Zack1010OP.

RELEASES.md Outdated Show resolved Hide resolved
docs/CARS.md Outdated Show resolved Hide resolved
@sunnyhaibin sunnyhaibin changed the title Hyundai: Car Port for 2022 Kona Electric (EV) Hyundai: Car Port for 2022 Kona Electric Jan 14, 2022
@sshane sshane self-assigned this Apr 29, 2022
@sshane
Copy link
Contributor

sshane commented Apr 30, 2022

According to @sunnyhaibin, this car has no radar, with the camera sending the SCC messages, so panda safety may be required to enable openpilot longitudinal control

@sshane
Copy link
Contributor

sshane commented Jun 11, 2022

After talk with @sunnyhaibin and looking at routes, some 2021 Kona Electrics have a radar, however the definitions and addresses are different, and the camera sends the SCC messages. The longitudinal safety should be the same as the 2022 Kanas, however we need to detect these different 2021 model year cars to use a different radar parser and not try to disable the radar. Hate to make a new platform for the same model year, what do you think @pd0wm?

Edit: seems like the owner was mistaken with his 2021 Kona EV, got the VIN manually from him and a single VIN decoder site says it's a 2022 model year (KMHK381GUNU147696, dongle 1d6ecb67ec23a1b8), so this may be much simpler than we first thought.

@sshane
Copy link
Contributor

sshane commented Jun 11, 2022

We will merge the car initially thought to be 2021 into this PR as we now believe that all these cars do have a radar but just for FCA and AEB (as seen in the radar FW version), then sunny will finish up the openpilot port and I'll help out with safety. If it turns out there's actually a difference (only thing would be the 2022's don't broadcast radar anywhere), then we can split out later

@sunnyhaibin sunnyhaibin marked this pull request as ready for review June 13, 2022 19:35
@sshane
Copy link
Contributor

sshane commented Jun 14, 2022

This car does not respond to sending buttons on bus 0 to cancel, will need to send on bus 2 to make it work

Screenshot from 2022-06-14 11-24-50

@sunnyhaibin sunnyhaibin changed the title Hyundai: Car Port for 2022 Kona Electric Hyundai: Car Port for 2022 Kona Electric Camera SCC Jun 20, 2022
@sunnyhaibin
Copy link
Contributor Author

@sshane User confirmed that button send from openpilot to resume from standstill works! 🎉

ff973b941a69366f|2022-07-28--22-01-19

This port should be ready to merge.

@sshane
Copy link
Contributor

sshane commented Jul 28, 2022

Can you have him test gas to disengage?

@sunnyhaibin
Copy link
Contributor Author

Can you have him test gas to disengage?

Will do! User mentioned he will have it tested in the AM his time.

@sunnyhaibin
Copy link
Contributor Author

@sshane ff973b941a69366f|2022-07-29--23-20-18 is the route that has disengage on gas per the user.

@sshane
Copy link
Contributor

sshane commented Aug 2, 2022

@sunnyhaibin That route has no disengage on gas on. However the route you added to test_models does disengage on gas, so I'll check that.

Seems to be working!

Screenshot from 2022-08-02 14-01-29

@sshane
Copy link
Contributor

sshane commented Aug 2, 2022

Didn't have too much data, but this car also seems like it has a lot of torque, similar to the other Konas. We'll need to limit it the same:
Screenshot from 2022-08-02 15-59-44

@sshane sshane merged commit 1ab63cc into commaai:master Aug 3, 2022
@sunnyhaibin sunnyhaibin deleted the master-kona-ev-2022-port branch September 1, 2023 16:08
sshane added a commit that referenced this pull request Mar 26, 2024
sshane added a commit that referenced this pull request Mar 26, 2024
* rm from ed882557605319f9

* rm from ffce4a1d578827ee

* rm from 700d37ccd12315cf

* can't find, but probably same

* rm from 15755effe9d073b1

* rm from 5b7caafa7ec1a5cf

* rm from ec07911a91f863f3

* rm from 7627c16a16a6f69b

* rm from 007d5e4ad9f86d13

* rm from 06a3b9e474ce581d

* rm from 22203eb8892a6f28

* rm from ff973b941a69366f

* rm from 3ea622c3c0ec3055

* rm from #23517

* rm from b0e1cdf87262c7ad

* old format FW version

* rm from 54f0bbcb6527012e & 4cbcc16b655c1591

* test abs

* format
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
* rm from ed882557605319f9

* rm from ffce4a1d578827ee

* rm from 700d37ccd12315cf

* can't find, but probably same

* rm from 15755effe9d073b1

* rm from 5b7caafa7ec1a5cf

* rm from ec07911a91f863f3

* rm from 7627c16a16a6f69b

* rm from 007d5e4ad9f86d13

* rm from 06a3b9e474ce581d

* rm from 22203eb8892a6f28

* rm from ff973b941a69366f

* rm from 3ea622c3c0ec3055

* rm from commaai#23517

* rm from b0e1cdf87262c7ad

* old format FW version

* rm from 54f0bbcb6527012e & 4cbcc16b655c1591

* test abs

* format
CT921 pushed a commit to TC1979/openpilot that referenced this pull request Oct 8, 2024
* rm from ed882557605319f9

* rm from ffce4a1d578827ee

* rm from 700d37ccd12315cf

* can't find, but probably same

* rm from 15755effe9d073b1

* rm from 5b7caafa7ec1a5cf

* rm from ec07911a91f863f3

* rm from 7627c16a16a6f69b

* rm from 007d5e4ad9f86d13

* rm from 06a3b9e474ce581d

* rm from 22203eb8892a6f28

* rm from ff973b941a69366f

* rm from 3ea622c3c0ec3055

* rm from commaai/openpilot#23517

* rm from b0e1cdf87262c7ad

* old format FW version

* rm from 54f0bbcb6527012e & 4cbcc16b655c1591

* test abs

* format
old-commit-hash: bbd08ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants