Disambiguate frame id in latencylogger #24164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gijskoning
reviewed
Apr 8, 2022
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
…biguate' into latencylogger_disambiguate
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
Apr 20, 2022
* add tools to disambiguate frame id * Update selfdrive/camerad/cameras/camera_qcom2.cc Co-authored-by: Gijs Koning <gijs-koning@live.nl> * bug fix * remove duplicate code * PR comments * bug fix Co-authored-by: Gijs Koning <gijs-koning@live.nl> Co-authored-by: Comma Device <device@comma.ai>
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
* add tools to disambiguate frame id * Update selfdrive/camerad/cameras/camera_qcom2.cc Co-authored-by: Gijs Koning <gijs-koning@live.nl> * bug fix * remove duplicate code * PR comments * bug fix Co-authored-by: Gijs Koning <gijs-koning@live.nl> Co-authored-by: Comma Device <device@comma.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same service for different frames overlap, there is ambiguity in when assigning frame id to a timestamp. In latencylogger, warn the user about this. The user can provide the frame id from the timestamp in these situations.