Carla pip dependency and fix for git init #24258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adeebshihadeh any reason you didn't do this in a3c26a9? Or just leftover when the carla in pip was broken? |
|
Just rebuilding the docker container is probably causing CI to fail (git upgrade to new version?). Feel free to do small fixes in this PR to fix CI, if it becomes too much split it out into a separate PR. |
Don’t remember. It’s probably fine to add it. |
gijskoning
commented
Apr 19, 2022
gijskoning
changed the title
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
* Add carla pip dependency for dev * Revert other packages in pipfile * Remove redundant carla install in docker * Fix CI Remove broken openpilot_build * New run command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running ./bridge.py fails on import Carla. This fixes it