swaglog: delay creating zmq socket to first use - fix modeld crash in sim #24271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd0wm
reviewed
Apr 20, 2022
pd0wm
reviewed
Apr 20, 2022
pd0wm
reviewed
Apr 20, 2022
pd0wm
changed the title
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
… sim (commaai#24271) * Initialize zmq socket later with initialize method * empty lines * Add lock and move initialize function * Check for initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes modeld crash in simulator. The zmq_socket was created at import leading to two sockets in one thread. This pr calls initialize() on the first usage of the logs.
Problem started here: #23596
Fixes #23666
And prs #24203 and #23792 can be closed.