Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: remove mismatched video #24307

Merged
merged 7 commits into from
Apr 24, 2022
Merged

Conversation

Azenzic
Copy link
Contributor

@Azenzic Azenzic commented Apr 24, 2022

update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the Hyundai G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid

update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid
fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV
add Kona EV 2021 to supported cars
@@ -42,7 +42,7 @@ class CAR:
IONIQ_PHEV_2019 = "HYUNDAI IONIQ PLUG-IN HYBRID 2019"
IONIQ_PHEV = "HYUNDAI IONIQ PHEV 2020"
KONA = "HYUNDAI KONA 2020"
KONA_EV = "HYUNDAI KONA ELECTRIC 2019"
KONA_EV = "HYUNDAI KONA ELECTRIC 2018-2021"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update the car info below, but this should be kept the same

@adeebshihadeh adeebshihadeh changed the title Fingerprint for Kona EV 2021 Hyundai: docs cleanup Apr 24, 2022
@adeebshihadeh adeebshihadeh changed the title Hyundai: docs cleanup Hyundai: remove mismatched video Apr 24, 2022
@adeebshihadeh adeebshihadeh merged commit b5f65a5 into commaai:master Apr 24, 2022
herman5 pushed a commit to herman5/openpilot that referenced this pull request Apr 29, 2022
* Fingerprint for Kona EV 2021

update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid

* Update values.py

* Update values.py

fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV

* Update CARS.md

add Kona EV 2021 to supported cars

* regenerate

* remove that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
spektor56 pushed a commit to spektor56/ghostpilot that referenced this pull request May 7, 2022
* Fingerprint for Kona EV 2021

update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid

* Update values.py

* Update values.py

fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV

* Update CARS.md

add Kona EV 2021 to supported cars

* regenerate

* remove that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
spektor56 pushed a commit to spektor56/ghostpilot that referenced this pull request May 7, 2022
* Fingerprint for Kona EV 2021

update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid

* Update values.py

* Update values.py

fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV

* Update CARS.md

add Kona EV 2021 to supported cars

* regenerate

* remove that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants