-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyundai: remove mismatched video #24307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019) 616f048bf31258b7|2022-04-23--20-38-39 616f048bf31258b7|2022-04-23--20-38-39--4 remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid
fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV
add Kona EV 2021 to supported cars
sshane
reviewed
Apr 24, 2022
selfdrive/car/hyundai/values.py
Outdated
@@ -42,7 +42,7 @@ class CAR: | |||
IONIQ_PHEV_2019 = "HYUNDAI IONIQ PLUG-IN HYBRID 2019" | |||
IONIQ_PHEV = "HYUNDAI IONIQ PHEV 2020" | |||
KONA = "HYUNDAI KONA 2020" | |||
KONA_EV = "HYUNDAI KONA ELECTRIC 2019" | |||
KONA_EV = "HYUNDAI KONA ELECTRIC 2018-2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can update the car info below, but this should be kept the same
herman5
pushed a commit
to herman5/openpilot
that referenced
this pull request
Apr 29, 2022
* Fingerprint for Kona EV 2021 update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019) 616f048bf31258b7|2022-04-23--20-38-39 616f048bf31258b7|2022-04-23--20-38-39--4 remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid * Update values.py * Update values.py fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV * Update CARS.md add Kona EV 2021 to supported cars * regenerate * remove that Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
* Fingerprint for Kona EV 2021 update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019) 616f048bf31258b7|2022-04-23--20-38-39 616f048bf31258b7|2022-04-23--20-38-39--4 remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid * Update values.py * Update values.py fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV * Update CARS.md add Kona EV 2021 to supported cars * regenerate * remove that Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
* Fingerprint for Kona EV 2021 update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the G harness ( the same as the 2019) 616f048bf31258b7|2022-04-23--20-38-39 616f048bf31258b7|2022-04-23--20-38-39--4 remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid * Update values.py * Update values.py fixed an open parentheses that could cause some issues added SCC+LFA requirement note on Kona EV * Update CARS.md add Kona EV 2021 to supported cars * regenerate * remove that Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update fingerprint to show support for Kona EV 2021 also the Kona EV 2021 uses the Hyundai G harness ( the same as the 2019)
616f048bf31258b7|2022-04-23--20-38-39
616f048bf31258b7|2022-04-23--20-38-39--4
remove improper youtube link that show a Hyundai Elantra driving listed next to a Kona hybrid