Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DH names + notes for MPC output curvatures #24701

Merged
merged 4 commits into from
Jun 7, 2022

Commits on Jun 1, 2022

  1. update names + notes for MPC outputs

    "current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
    The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
    inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate. 
    
    If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct. 
    This was possibly how it was initially set up but the nomenclature here is now confusing.
    ClockeNessMnstr authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fc18dfb View commit details
    Browse the repository at this point in the history
  2. more notes

    ClockeNessMnstr committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    54dd33f View commit details
    Browse the repository at this point in the history
  3. match

    ClockeNessMnstr committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    621143d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Clarify #1

    ClockeNessMnstr committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    bb0ffa1 View commit details
    Browse the repository at this point in the history