Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW MQB: Update supported models and model-years #25123

Merged
merged 9 commits into from
Jul 14, 2022

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Jul 12, 2022

WIP, draft.

  • General

    • Extend model-year support to known boundaries (full range when able, USA boundaries when conflicting)
    • Add the J533 harness/footnote for vehicles that got the 2Q0 camera in ~2021
    • Start consolidating sedan-vs-wagon model distinctions before this becomes volkswagenpilot
  • Volkswagen Arteon

    • Add R and eHybrid versions
    • Add Shooting Brake versions for all (via footnote)
    • Add Volkswagen CC (Chinese market branding for the Arteon) (no MY overlap with the old PQ Passat/CC)
  • Volkswagen Atlas

    • Add Teramont branding (branding for Atlas outside of USA and Middle East) and Teramont-only X version
    • Add Cross Sport versions of Atlas and Teramont
  • Volkswagen Golf

    • Add Golf GTD (TDI version of GTI)
    • TODO: Could add GTI Clubsport, Clubsport S, and GTI TCR here if ACC availability can be confirmed
    • Drop SportWagen in favor of the wagon footnote on Golf, it's called Variant or Estate outside the USA
    • There's a Golf R Variant/Estate outside the USA
    • TODO: some more tuning of Mk7 final model-years
  • Volkswagen Jetta

    • TODO: research whether we should add Volkswagen Sagitar as an alias for the Chinese market, conflicting info
  • Volkswagen Passat

    • Add Passat Alltrack
    • Add Passat GTE
    • Add wagon variants for all via footnote
  • Volkswagen Polo

    • Add Polo GTI
    • TODO: may be able to start support one or two model-years earlier but has to be tested
    • TODO: research adding Volkswagen Virtus (LATAM/India version of Polo) here, modified wheelbase

@sshane sshane added docs car vehicle-specific volkswagen labels Jul 12, 2022
@sshane
Copy link
Contributor

sshane commented Jul 14, 2022

Is this good to go?

@jyoung8607
Copy link
Collaborator Author

I have many more models still left to review, but the work so far is good to merge if you like.

@jyoung8607 jyoung8607 marked this pull request as ready for review July 14, 2022 19:38
@sshane sshane merged commit e203794 into commaai:master Jul 14, 2022
@jyoung8607 jyoung8607 deleted the mqb-model-and-year-updates branch July 14, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants