Add Dutch translations (Nederlands) #25327

jeroenlammersma · 2022-08-01T19:31:40Z

Added Dutch translations
Only 'minutes ago' and 'days ago' on lines 639 and 649 could be improved. In English you append an 's' if it's more than 1. However, in Dutch it's like this:

minute = minuut
minutes = minuten

day = dag
days = dagen

This is my solution to this issue:

Minutes:

<source>%1 minute%2 ago</source>
<translation>%1 min. geleden</translation>

Days:

<source>%1 day%2 ago</source>
<translation>%1 dag(en) geleden</translation>

But this solution is not optimal, it could be improved.

sshane · 2022-08-01T21:37:27Z

Thanks for the PR! Qt has a way to handle plurals in different languages, I just haven't gotten around to doing it yet. https://doc.qt.io/qt-6/i18n-source-translation.html

jeroenlammersma · 2022-08-02T17:38:36Z

You're welcome! More work than I initially anticipated, but I liked doing it.

If I have some spare time in the near future, I could have a look at handling plurals. But first, I need to finish my openpilot graduation project :)

In the meantime I thought about some improvements to the current translation and implemented them.

sshane · 2022-08-02T20:24:25Z

Could you check if I converted to plurals correctly?

jeroenlammersma · 2022-08-02T20:54:13Z

Yes you converted them correctly!

Just wondering, does it also take into account 0 values? So for example:

0 minutes
0 days

Will this translate to

0 minuten
0 dagen

also plural?

sshane · 2022-08-02T20:56:38Z

I know it does for English, so most likely

jeroenlammersma · 2022-08-02T21:08:05Z

Ok nice, then the translations will be correct for 0 values as well.

If you need more Dutch translations in the future, tag me or send me an email :)

selfdrive/ui/translations/main_nl.ts

Thanks for the review Willem! Co-authored-by: Willem Melching <willem.melching@gmail.com>

jeroenlammersma · 2022-08-03T20:35:15Z

@sshane @pd0wm, maybe it's a good idea to add images of the UI, so you can easily see all source text 'in action'. Some texts really need context in order to translate them correctly. That could benefit the overall quality of a translation and may help potential future contributors.

What do you think?

selfdrive/ui/translations/main_nl.ts

sshane · 2022-08-19T07:13:21Z

Opened relevant issue: #25492

jeroenlammersma

Seems right.

jeroenlammersma

Is outdated. Fixed it already by pushing an update. (Btw: I finally figured out how this 'change request' thing works on GitHub, so will do it the right way next time.)

#3) * Rename KIA_NIRO_HEV to KIA_NIRO_PHEV (commaai#24216) * Add car port: Kia Niro Plug-In Hybrid 2018 * Add additional FW version * Low speed lockout 32 MPH * Add test route * min_steer_speed in CarInfo * Remove min_steer_speed from CarInfo * Add to CARS.md * run generator * update min enable speed and regen * update ci routes * these are the same car * i think we only add a note if it's a new platform * fix HEV -> PHEV * Add test route * dup fw * haha we already support this car in commaai#25187 Co-authored-by: Shane Smiskol <shane@smiskol.com> * GM pcmCruise: cancel more reliably (commaai#25454) * Cancel more reliably * Apply suggestions from code review * Try sending multiple * Apply suggestions from code review * Apply suggestions from code review * Update selfdrive/car/gm/carcontroller.py * lower rate a bit * try this * Update selfdrive/car/gm/carcontroller.py * bump panda * Car docs: add more videos (commaai#25494) * Add Civic video * add mazda cx-9 2022 video link * GM Bolt EUV: update supported packages (commaai#25496) * Update values.py * Update selfdrive/car/gm/values.py Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * update docs Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * Hyundai: common CAN-FD gear signal (commaai#25498) * Hyundai: common CAN-FD gear signal * bump opendbc * GM: Chevy Silverado 2020-21 support (commaai#25429) * Silverado support Co-authored-by: Jason Shuler <jshuler@gmail.com> * Update docs * Try 2 m/s/s * Should be good torque values * Add Silverado test route * Add to releases * Send counter * can't send multiple or it faults * Send at 33hz, no counter * try 25hz, don't line up exactly with car's buttons * never tried 10hz with same counter * Update selfdrive/car/gm/gmcan.py * Make same as pcmCruise branch * update year and package (different packages needed per-trim) * Update year in releases * Revert to 21 * We can use this package name again * wrong one! Co-authored-by: Shane Smiskol <shane@smiskol.com> * Show CAN error if message counters are invalid (commaai#25497) * counter check affects can valid * Apply suggestions from code review * bump to master * Hyundai: Car Port for Tucson Hybrid 2022 (commaai#25276) * Hyundai: Car Port for Tucson Hybrid 2022 * Update RELEASES.md * Init gear_msg at the top * FW versions from script * Button send attempt * start with some cleanup * Send button fixed bits * Define all bytes and only send PAUSE/RESUME * Use CRUISE_INFO to cancel cruise and resume * 8-bit counter * Cleanup ish * 8 bit counter * Send at 20ms * Disengage bits * Revert bump submodules * Allow tx on 0x1a0 * Fix byte counts * Send LFA and HDA icons based on engageability * Send cruise buttons only on HDA2 cars for now * Add comments * Add FLAG_HYUNDAI_CANFD_HDA2 flag * Update interface.py * Update carstate.py * Update carstate.py * Update carstate.py * Bump submodules * Bump panda * Bump opendbc * Allow tx with CRUISE_INACTIVE * GEAR has 24 bytes only * Generate car docs * Fix CRUISE_INFO copy * Remove unused class * Add CAN-FD busses to unit test * Bump opendbc * Revert "Add CAN-FD busses to unit test" This reverts commit 2f75164. * Remove duplicate * New tune based on data * Panda safety cleanup * Include bus 0 in rx checks * Missed one * bus 6 check * Remove redundant check * Add comments * Bump opendbc * Sync with DBC * Hide LFA icon when disengaged * Little endian * fix comment * more conditions in carcontroller * update pedal signal * update tuning * cleanup carcontroller * bump panda * fix mismatch * alt buttons * little more cleanup * update refs for EV6 new safety param * bump panda Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * remove old boardd stuff * Ford: add CADS radar interface (commaai#24296) * Ford: use FORD_CADS radar dbc * Ford: CADS radar interface impl Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> * fixup radar interface for FORD_CADS dbc * CADS treat different scan indexes as separate points * Ford: support both Fusion and CADS radars * Ford: rename radars to DELPHI_ESR and DELPHI_MRR Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> * 0.8.16 release notes * test_models: no CAN invalid tolerance (commaai#25501) * don't use end of route segment * no can invalid cnt tolerance * start checking can valid immediately once available * we check counter violations * README.md: update grammar (commaai#25488) * first paragraph * second section * second section pt2 * third section * fifth section * fifth section pt2 * sixth section * Apply suggestions from code review Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * setup: perform all pyenv setup in a single place (commaai#23408) * consolidate pyenv setup * cleanup openpilot_env.sh * undo openpilot_env.sh changes * needed on mac * add that back Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * v4l_encoder: free buf_out in destructor (commaai#25044) * test onroad: update dmonitoringd cpu usage * CI: Actions cleanup + speedup (commaai#25514) * actions cache cleanup * release build cleanup * fetch dpeth * sim: fix gps message (commaai#25521) fix gps timestamp field renamed bug introduced in commaai/msgq#341 * GMC: Sierra 2020-21 support (commaai#25523) * Add Sierra * actually this package works * add to releases * credit * GM: add Silverado 2021 High Country FP (commaai#25499) * Add FP from 61c6258cac78af08 * add to dict * Update Silverado release note (commaai#25526) * Translations badges: concatenate into one badge (commaai#25522) * add badge done correctly works Update translation_badge.svg Update translation_badge.svg Update translation_badge.svg Update README.md Update translation_badge.svg Update translation_badge.svg Update translation_badge.svg Update badge Update README.md test this try this finalize remove badges fixup readme add to test fix fix rm * clean up * no formats * Fix badge workflow * user event flagging (commaai#25517) * setup home_btn in sidebar * create UserFlag msg * replay: show and skip to user flags * update translations * bump to cereal master * remove comment Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * Update translations * Toyota: add missing engine and esp FW for Corolla Cross Hybrid (commaai#25532) add missing engine and esp FW for CorollaCross Hybrid DongleId 147613502316e718 * HKG: Add FW for 2018 Kia Stinger (commaai#25531) * HKG: Add FW for 2008 Kia Stinger * 2018 in disguise Co-authored-by: Shane Smiskol <shane@smiskol.com> * test_models: pass carFw into car interface (commaai#25535) pass carFw into get_params * Add Thai translations (commaai#25189) * Add Thai translations * update to add plurals remove * Update translations * Update Thai translation to match English source. * Add to badges * use shorter km/h * Add test for correct format specifier for plural translations * pass new test * Update some sentences to make it clear. Change short form of some words. * Hide from the UI Co-authored-by: Shane Smiskol <shane@smiskol.com> * update car candidate docs (commaai#25536) * update car candidate docs * little more * that's a nice wikipedia * quotes * Silence a PytestCollectionWarning (commaai#25537) Silence PytestCollectionWarning: cannot collect test class 'TestRoute' because it has a __new__ constructor (from: test_models.py) * bump version to 0.8.17 * Toyota: log stockAeb on non-TSS2 cars (commaai#25489) * check PRE_COLLISION * need to make sure this is right * revert * temp, stash * fixes * uncomment that * it's not really cruise/pcm, but acc remove improt * revert * Fix CI * revert exception * Revert "revert exception" This reverts commit 7e2f390. * this tested enableDsu, but we have other routes that do that * use segment from db * remove exception again Co-authored-by: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com> Co-authored-by: Shane Smiskol <shane@smiskol.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Jason Shuler <jshuler@gmail.com> Co-authored-by: Cameron Clough <cameronjclough@gmail.com> Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> Co-authored-by: Joseph Wagner <68037585+wjoseph0@users.noreply.github.com> Co-authored-by: Greg Hogan <gregjhogan@gmail.com> Co-authored-by: Dean Lee <deanlee3@gmail.com> Co-authored-by: AlexandreSato <66435071+AlexandreSato@users.noreply.github.com> Co-authored-by: Rewat S <76684800+taperec@users.noreply.github.com>

jeroenlammersma · 2022-08-24T15:24:10Z

I ran update_translations.py but this changes nothing:

main_en.ts:
Found 233 source text(s) (229 new and 4 already existing)

rest:
Found 233 source text(s) (0 new and 233 already existing)

Do you know where the issue lies?

Btw, would update_translations.py be a useful pre-commit hook?

jeroenlammersma

Outdated, but already fixed 'CONTROLEREN' (will do review changes request right next time, figured it out)

jeroenlammersma · 2022-08-25T23:52:00Z

Okay little bit lost now, I am new to reviewing changes on GitHub et cetera😅. What am I doing wrong exactly that the 'change requested' is still open? Sorry for the inconvenience btw.

selfdrive/ui/translations/languages.json

Co-authored-by: Shane Smiskol <shane@smiskol.com>

jeroenlammersma · 2022-08-31T21:05:38Z

Nice!🙂

Like I said earlier, if you need new Dutch translations, you can send me a message or email!

jeroenlammersma · 2022-10-11T07:48:40Z

Hi Shane, Yeay sure, I’d be happy helping out to keep the Dutch translation up to date. And luckily you can also pull Willem’s sleeve for reviewing so now and then :) Cheers, Jeroen From: Shane Smiskol ***@***.***> Sent: 03 August 2022 04:55 To: commaai/openpilot ***@***.***> Cc: Jeroen ***@***.***>; Author ***@***.***> Subject: Re: [commaai/openpilot] Add Dutch translations (Nederlands) (PR #25327) Just wanted to check, seems like Dutch is a relatively popular language with openpilot after English, Mandarin, Japanese, Korean, Swedish, and German. And we already have half of those, so if you're willing to chip in here and there to make sure it's up to date before releases I'd be happy merging. Ideally and eventually more and more people can start contributing. — Reply to this email directly, view it on GitHub <#25327 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH6N6XJN7NT2CLXXN4FK6W3VXHNPNANCNFSM55IUKUYA> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AH6N6XMUPBPCRQSL2Z2UOI3VXHNPNA5CNFSM55IUKUYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI65NASI.gif> Message ID: ***@***.*** ***@***.***> >

Add Dutch translations (Nederlands)

851d8a9

sshane added the multilanguage label Aug 1, 2022

Dutch translation improvements

4f01b57

sshane added 2 commits August 2, 2022 13:18

Merge remote-tracking branch 'upstream/master' into dutch-translations

0f4ff30

Use Qt's plurals

8561e80

sshane reviewed Aug 3, 2022

View reviewed changes