modeld: PC Thneed prereqs #25615
Merged
modeld: PC Thneed prereqs #25615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge if tests pass |
jflorchi
pushed a commit
to jflorchi/openpilot
that referenced
this pull request
Sep 1, 2022
This reverts commit b6e355a.
rjsmith1999
pushed a commit
to rjsmith1999/openpilot
that referenced
this pull request
Oct 8, 2022
* pc thneed prereqs * ugh, out of date * that can stay private * memcpy here is fine in SNPE variant * release files * thneed docs don't work anymore. they didn't look too useful Co-authored-by: Comma Device <device@comma.ai>
rjsmith1999
pushed a commit
to rjsmith1999/openpilot
that referenced
this pull request
Oct 10, 2022
* pc thneed prereqs * ugh, out of date * that can stay private * memcpy here is fine in SNPE variant * release files * thneed docs don't work anymore. they didn't look too useful Co-authored-by: Comma Device <device@comma.ai>
rjsmith1999
pushed a commit
to rjsmith1999/openpilot
that referenced
this pull request
Oct 10, 2022
* pc thneed prereqs * ugh, out of date * that can stay private * memcpy here is fine in SNPE variant * release files * thneed docs don't work anymore. they didn't look too useful Co-authored-by: Comma Device <device@comma.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the tinygrad PR smaller.
Mostly it refactors thneed.cc into thneed_common.cc (used on PC), and thneed_qcom2.cc (Adreno specific stuff). A good refactor regardless.
It also adds passing in the cl_context to the model runners so they can reuse it. On PC this is required.