-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes wobble on new CRV #269
Conversation
@pd0wm I don't think this is specific to high speed, seems to oscillate at any speed, if so, is this an appropriate fix? |
How did you take does graph? I wanted to fix the oscillation for the Prius Prime so I lower the same value and it seems to work well. It's not perfect but it's much better. By the way, I think the ret.steerKpV is to center the car in line. From experience, when you lower the value, the car stay in lane but more to le left. |
Those graphs are made in cabana -> cabana.comma.ai |
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
b875f970f Stricter pylint daf3bc988 HRV correct GAS_PEDAL (#266) c25b757ac Update X-trail HUD message name, added SPEED_MPH signal (#269) 1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment git-subtree-dir: opendbc git-subtree-split: b875f970fc6ddad5befe2f6831f4bcda354d8bea
Prior to actuator delay update, I felt like .8/.24 was working well here. After this change though, steer oscillation is very apparent, maybe worst than before. Dropping this value proportionately by 1/4 seems to effectively remove wobble and drastically improves drive-quality.