ui: experimental -> alpha OP long toggle #27725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
changed the title
|
Thanks for the PR! I reverted the change to the ordering to ensure the expanded version of the Experimental mode toggle shows without having to scroll. |
pfeiferj
pushed a commit
to pfeiferj/pfeifer-pilot-patches
that referenced
this pull request
Apr 11, 2023
* swap locations * remove experimental from toggle name * revert * alpha * revert that --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find these two toggles to be a little confusing. You can't enable "Experimental Mode" without having "Experimental openpilot Longitudinal Control" enabled, so the order should be flipped. Both toggles include the word experimental which might be confusing to new users.
to