Subaru: log stock AEB #28052
Merged
Subaru: log stock AEB #28052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Apr 27, 2023
sshane
reviewed
Apr 28, 2023
|
@sshane this good to merge? |
|
Not quite, LKAS_Alert_Msg activates too late and stays on for too long. Think I found the real AEB actuation bit in the ES_Brake message though
The Msg signal can fail to activate at all when the user is already braking:
|
|
LGTM! Posted notes in the opendbc PR |
sshane
reviewed
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stock AEB dash signals logging (from #25345) and adds FCW_Cont_Beep alert to stockFcw